From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: <jeffrey.t.kirsher@intel.com>, <intel-wired-lan@lists.osuosl.org>,
<maurosr@linux.vnet.ibm.com>, <stable@vger.kernel.org>,
<alexander.h.duyck@intel.com>, <muvic@linux.vnet.ibm.com>,
<brking@pobox.com>
Subject: Re: [PATCH v2 3/7] ixgbevf: Use smp_rmb rather than read_barrier_depends
Date: Tue, 21 Nov 2017 09:37:58 -0800 [thread overview]
Message-ID: <20171121093758.00007ad6@intel.com> (raw)
In-Reply-To: <1510938349-17608-4-git-send-email-brking@linux.vnet.ibm.com>
On Fri, 17 Nov 2017 11:05:45 -0600
Brian King <brking@linux.vnet.ibm.com> wrote:
> The original issue being fixed in this patch was seen with the ixgbe
> driver, but the same issue exists with ixgbevf as well, as the code is
> very similar. read_barrier_depends is not sufficient to ensure
> loads following it are not speculatively loaded out of order
> by the CPU, which can result in stale data being loaded, causing
> potential system crashes.
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2017-11-21 17:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 17:05 [PATCH v2 0/7] [net] intel: Use smp_rmb rather than read_barrier_depends Brian King
2017-11-17 17:05 ` [PATCH v2 1/7] ixgbe: Fix skb list corruption on Power systems Brian King
2017-11-21 17:36 ` Jesse Brandeburg
2017-11-17 17:05 ` [PATCH v2 2/7] i40e: Use smp_rmb rather than read_barrier_depends Brian King
2017-11-21 17:37 ` Jesse Brandeburg
2017-11-17 17:05 ` [PATCH v2 3/7] ixgbevf: " Brian King
2017-11-21 17:37 ` Jesse Brandeburg [this message]
2017-11-17 17:05 ` [PATCH v2 4/7] igbvf: " Brian King
2017-11-21 17:38 ` Jesse Brandeburg
2017-11-22 5:32 ` [Intel-wired-lan] " Brown, Aaron F
2017-11-17 17:05 ` [PATCH v2 5/7] igb: " Brian King
2017-11-21 17:39 ` Jesse Brandeburg
2017-11-22 3:14 ` [Intel-wired-lan] " Brown, Aaron F
2017-11-17 17:05 ` [PATCH v2 6/7] fm10k: " Brian King
2017-11-21 17:39 ` Jesse Brandeburg
2017-11-17 17:05 ` [PATCH v2 7/7] i40evf: " Brian King
2017-11-21 17:40 ` Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121093758.00007ad6@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=brking@linux.vnet.ibm.com \
--cc=brking@pobox.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=maurosr@linux.vnet.ibm.com \
--cc=muvic@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).