From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mga03.intel.com ([134.134.136.65]:26982 "EHLO mga03.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751191AbdKURit (ORCPT <rfc822;stable@vger.kernel.org>);
        Tue, 21 Nov 2017 12:38:49 -0500
Date: Tue, 21 Nov 2017 09:38:29 -0800
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: <jeffrey.t.kirsher@intel.com>, <intel-wired-lan@lists.osuosl.org>,
        <maurosr@linux.vnet.ibm.com>, <stable@vger.kernel.org>,
        <alexander.h.duyck@intel.com>, <muvic@linux.vnet.ibm.com>,
        <brking@pobox.com>
Subject: Re: [PATCH v2 4/7] igbvf: Use smp_rmb rather than
 read_barrier_depends
Message-ID: <20171121093829.000042f2@intel.com>
In-Reply-To: <1510938349-17608-5-git-send-email-brking@linux.vnet.ibm.com>
References: <1510938349-17608-1-git-send-email-brking@linux.vnet.ibm.com>
        <1510938349-17608-5-git-send-email-brking@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Fri, 17 Nov 2017 11:05:46 -0600
Brian King <brking@linux.vnet.ibm.com> wrote:

> The original issue being fixed in this patch was seen with the ixgbe
> driver, but the same issue exists with igbvf as well, as the code is
> very similar. read_barrier_depends is not sufficient to ensure
> loads following it are not speculatively loaded out of order
> by the CPU, which can result in stale data being loaded, causing
> potential system crashes.

Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>