From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com ([66.111.4.28]:57901 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752741AbdKWPTp (ORCPT ); Thu, 23 Nov 2017 10:19:45 -0500 Date: Thu, 23 Nov 2017 16:19:50 +0100 From: Greg KH To: Oliver Neukum Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] USB: usbfs: Filter flags passed in from user space Message-ID: <20171123151950.GA26798@kroah.com> References: <20171123142834.29602-1-oneukum@suse.com> <20171123145721.GA18622@kroah.com> <1511449588.27393.0.camel@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511449588.27393.0.camel@suse.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Nov 23, 2017 at 04:06:28PM +0100, Oliver Neukum wrote: > Am Donnerstag, den 23.11.2017, 15:57 +0100 schrieb Greg KH: > > On Thu, Nov 23, 2017 at 03:28:34PM +0100, Oliver Neukum wrote: > > > > > > USBDEVFS_URB_ISO_ASAP must be accepted only for ISO endpoints. > > > Improve sanity checking. > > > > > > Signed-off-by: Oliver Neukum > > > --- > > > drivers/usb/core/devio.c | 16 ++++++++++------ > > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > Didn't we do something like this already? > > I sent a patch. Alan found it insufficient. Ah, ok. > > Or was it something else? Was this triggered by some testing? > > Alexey's syzkaller tests showed that you can trigger it. Then a nice "Reported-by:" would be good to add, as would a stable tree inclusion, right? thanks, greg k-h