stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Jiri Slaby <jslaby@suse.cz>,
	jaewon31.kim@samsung.com, akpm@linux-foundation.org,
	js1304@gmail.com, minchan@kernel.org, stable@vger.kernel.org,
	torvalds@linux-foundation.org, Yang Shi <yang.shi@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mm: check the return value of lookup_page_ext for all call sites
Date: Fri, 24 Nov 2017 10:39:46 +0100	[thread overview]
Message-ID: <20171124093946.GA13309@kroah.com> (raw)
In-Reply-To: <20171124093032.32071-1-mhocko@kernel.org>

On Fri, Nov 24, 2017 at 10:30:32AM +0100, Michal Hocko wrote:
> From: Yang Shi <yang.shi@linaro.org>
> 
> commit f86e4271978bd93db466d6a95dad4b0fdcdb04f6 upstream.
> 
> Per the discussion with Joonsoo Kim [1], we need check the return value
> of lookup_page_ext() for all call sites since it might return NULL in
> some cases, although it is unlikely, i.e.  memory hotplug.
> 
> Tested with ltp with "page_owner=0".
> 
> [1] http://lkml.kernel.org/r/20160519002809.GA10245@js1304-P5Q-DELUXE
> 
> [akpm@linux-foundation.org: fix build-breaking typos]
> [arnd@arndb.de: fix build problems from lookup_page_ext]
>   Link: http://lkml.kernel.org/r/6285269.2CksypHdYp@wuerfel
> [akpm@linux-foundation.org: coding-style fixes]
> Link: http://lkml.kernel.org/r/1464023768-31025-1-git-send-email-yang.shi@linaro.org
> Signed-off-by: Yang Shi <yang.shi@linaro.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Michal Hocko <mhocko@suse.com>

Can you send a patch on top of 4.4.101 to resolve this instead?

thanks,

greg k-h

  reply	other threads:[~2017-11-24  9:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-22  8:37 FAILED: patch "[PATCH] mm/page_ext.c: check if page_ext is not prepared" failed to apply to 4.4-stable tree gregkh
2017-11-22  9:47 ` Michal Hocko
2017-11-22  9:54   ` Greg KH
2017-11-22 12:08     ` Michal Hocko
2017-11-22 12:09 ` [PATCH stable-4.4 1/2] mm: check the return value of lookup_page_ext for all call sites Michal Hocko
2017-11-22 12:09   ` [PATCH stable-4.4 2/2] mm/page_ext.c: check if page_ext is not prepared Michal Hocko
2017-11-22 14:04   ` [PATCH stable-4.4 1/2] mm: check the return value of lookup_page_ext for all call sites Greg KH
2017-11-24  9:17   ` Jiri Slaby
2017-11-24  9:28     ` Michal Hocko
2017-11-24  9:29       ` Jiri Slaby
2017-11-24  9:39         ` Michal Hocko
2017-11-24 10:14           ` Greg KH
2017-11-24  9:30       ` [PATCH] " Michal Hocko
2017-11-24  9:39         ` Greg KH [this message]
2017-12-05 16:16   ` [PATCH stable-4.4 1/2] " Ben Hutchings
2017-12-05 16:17     ` Ben Hutchings
2017-12-05 19:16     ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171124093946.GA13309@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jaewon31.kim@samsung.com \
    --cc=js1304@gmail.com \
    --cc=jslaby@suse.cz \
    --cc=mhocko@kernel.org \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=yang.shi@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).