From: Christoph Hellwig <hch@infradead.org>
To: Michael Lyle <mlyle@lyle.org>
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
axboe@kernel.dk, Huacai Chen <chenhc@lemote.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/4] bcache: Fix building error on MIPS
Date: Tue, 28 Nov 2017 05:42:21 -0800 [thread overview]
Message-ID: <20171128134221.GA16064@infradead.org> (raw)
In-Reply-To: <20171124231427.9563-3-mlyle@lyle.org>
> diff --git a/include/uapi/linux/bcache.h b/include/uapi/linux/bcache.h
> index 90fc490f973f..821f71a2e48f 100644
> --- a/include/uapi/linux/bcache.h
> +++ b/include/uapi/linux/bcache.h
> @@ -91,7 +91,7 @@ PTR_FIELD(PTR_GEN, 0, 8)
>
> #define PTR_CHECK_DEV ((1 << PTR_DEV_BITS) - 1)
>
> -#define PTR(gen, offset, dev) \
> +#define MAKE_PTR(gen, offset, dev) \
> ((((__u64) dev) << 51) | ((__u64) offset) << 8 | gen)
This really should have a BCACHE_ prefix, and probably a lower case
name. And last but not least it really shouldn't be in a uapi header.
Similar things apply to various other things around it.
next prev parent reply other threads:[~2017-11-28 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171124231427.9563-1-mlyle@lyle.org>
2017-11-24 23:14 ` [PATCH 2/4] bcache: Fix building error on MIPS Michael Lyle
2017-11-28 13:42 ` Christoph Hellwig [this message]
2017-11-24 23:14 ` [PATCH 3/4] bcache: recover data from backing when data is clean Michael Lyle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128134221.GA16064@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=chenhc@lemote.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mlyle@lyle.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).