stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: motobud@gmail.com
To: gregkh@linuxfoundation.org
Cc: boris.brezillon@free-electrons.com,
	Brent Taylor <motobud@gmail.com>,
	stable@vger.kernel.org
Subject: [PATCH] mtd: nand: Fix writing mtdoops to nand flash
Date: Tue, 28 Nov 2017 23:13:47 -0600	[thread overview]
Message-ID: <20171129051347.1549-1-motobud@gmail.com> (raw)

From: Brent Taylor <motobud@gmail.com>

Gregg,
  I apologize for the 4.4.y patch, I screwed up the branching 
in my local tree and tried to submit one patch that would cover 
versions 4.4.y and 3.18.y.  Here is a valid 4.4.y patch.
  -- Brent

commit 30863e38ebeb500a31cecee8096fb5002677dd9b upstream.

When mtdoops calls mtd_panic_write(), it eventually calls
panic_nand_write() in nand_base.c. In order to properly wait for the
nand chip to be ready in panic_nand_wait(), the chip must first be
selected.

When using the atmel nand flash controller, a panic would occur due to
a NULL pointer exception.

Fixes: 2af7c6539931 ("mtd: Add panic_write for NAND flashes")
Cc: <stable@vger.kernel.org> # 4.4.x
Signed-off-by: Brent Taylor <motobud@gmail.com>
---
 drivers/mtd/nand/nand_base.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 54ab48827258..7ba109e8cf88 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2663,15 +2663,18 @@ static int panic_nand_write(struct mtd_info *mtd, loff_t to, size_t len,
 			    size_t *retlen, const uint8_t *buf)
 {
 	struct nand_chip *chip = mtd->priv;
+	int chipnr = (int)(to >> chip->chip_shift);
 	struct mtd_oob_ops ops;
 	int ret;
 
-	/* Wait for the device to get ready */
-	panic_nand_wait(mtd, chip, 400);
-
 	/* Grab the device */
 	panic_nand_get_device(chip, mtd, FL_WRITING);
 
+	chip->select_chip(mtd, chipnr);
+
+	/* Wait for the device to get ready */
+	panic_nand_wait(mtd, chip, 400);
+
 	memset(&ops, 0, sizeof(ops));
 	ops.len = len;
 	ops.datbuf = (uint8_t *)buf;
-- 
2.15.0

             reply	other threads:[~2017-11-29  5:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29  5:13 motobud [this message]
2017-12-04 12:14 ` [PATCH] mtd: nand: Fix writing mtdoops to nand flash Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2017-11-28  5:59 motobud
2017-11-28  8:42 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171129051347.1549-1-motobud@gmail.com \
    --to=motobud@gmail.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).