From: Jason Gunthorpe <jgg@ziepe.ca>
To: Mike Marciniszyn <mike.marciniszyn@intel.com>
Cc: stable@vger.kernel.org, linux-rdma@vger.kernel.org,
stable-commits@vger.kernel.org
Subject: Re: [PATCH 2/2] IB/hfi1: Do not warn on lid conversions for OPA
Date: Wed, 29 Nov 2017 11:43:24 -0700 [thread overview]
Message-ID: <20171129184324.GF4011@ziepe.ca> (raw)
In-Reply-To: <20171129125948.31113.59826.stgit@phlsvslse11.ph.intel.com>
On Wed, Nov 29, 2017 at 07:59:49AM -0500, Mike Marciniszyn wrote:
> From: Don Hiatt <don.hiatt@intel.com>
>
> Upstream commit 4988be5813ff2afdc0d8bfa315ef34a577d3efbf.
>
> On OPA devices opa_local_smp_check will receive 32Bit LIDs when the LID
> is Extended. In such cases, it is okay to lose the upper 16 bits of the
> LID as this information is obtained elsewhere. Do not issue a warning
> when calling ib_lid_cpu16() in this case by masking out the upper 16Bits.
The concept for the 32 bit lids was to keep it 32 bit inside the
kernel, ingress_key_table_fail puts the lid into
err_info_constraint.slid which is already 32 bits, so this cannot be
the right place for this.
These truncations should only appear at the uapi boundary.
Jason
next prev parent reply other threads:[~2017-11-29 18:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 12:59 [PATCH 1/2] IB/core: Do not warn on lid conversions for OPA Mike Marciniszyn
2017-11-29 12:59 ` [PATCH 2/2] IB/hfi1: " Mike Marciniszyn
2017-11-29 18:43 ` Jason Gunthorpe [this message]
2017-12-04 12:13 ` Greg KH
2017-12-04 17:28 ` Don Hiatt
2017-11-29 18:17 ` [PATCH 1/2] IB/core: " Parav Pandit
2017-12-04 12:11 ` Greg KH
2017-12-04 17:28 ` Don Hiatt
2017-12-05 4:04 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129184324.GF4011@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).