From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-wm0-f47.google.com ([74.125.82.47]:35552 "EHLO
        mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751791AbdK2Sn2 (ORCPT
        <rfc822;stable@vger.kernel.org>); Wed, 29 Nov 2017 13:43:28 -0500
Received: by mail-wm0-f47.google.com with SMTP id f9so7979653wmh.0
        for <stable@vger.kernel.org>; Wed, 29 Nov 2017 10:43:28 -0800 (PST)
Date: Wed, 29 Nov 2017 11:43:24 -0700
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Mike Marciniszyn <mike.marciniszyn@intel.com>
Cc: stable@vger.kernel.org, linux-rdma@vger.kernel.org,
        stable-commits@vger.kernel.org
Subject: Re: [PATCH 2/2] IB/hfi1: Do not warn on lid conversions for OPA
Message-ID: <20171129184324.GF4011@ziepe.ca>
References: <20171129125943.31113.29038.stgit@phlsvslse11.ph.intel.com>
 <20171129125948.31113.59826.stgit@phlsvslse11.ph.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171129125948.31113.59826.stgit@phlsvslse11.ph.intel.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Wed, Nov 29, 2017 at 07:59:49AM -0500, Mike Marciniszyn wrote:
> From: Don Hiatt <don.hiatt@intel.com>
> 
> Upstream commit 4988be5813ff2afdc0d8bfa315ef34a577d3efbf.
> 
> On OPA devices opa_local_smp_check will receive 32Bit LIDs when the LID
> is Extended. In such cases, it is okay to lose the upper 16 bits of the
> LID as this information is obtained elsewhere. Do not issue a warning
> when calling ib_lid_cpu16() in this case by masking out the upper 16Bits.

The concept for the 32 bit lids was to keep it 32 bit inside the
kernel, ingress_key_table_fail puts the lid into
err_info_constraint.slid which is already 32 bits, so this cannot be
the right place for this.

These truncations should only appear at the uapi boundary.

Jason