[PATCH] x86/efi-bgrt: Replace early_memremap() with memremap()

[PATCH] x86/efi-bgrt: Replace early_memremap() with memremap()

[Ghannam, Yazen]

Upstream commit ID: e2c90dd7e11e3025b46719a79fb4bb1e7a5cef9f
Prerequisite commit: "50a0cb565246 x86/efi-bgrt: Fix kernel panic when mapping BGRT data"

Reason: Fixes the following call trace on AMD Fam17h systems.
[  +0.019604] ------------[ cut here ]------------
[  +0.000008] WARNING: CPU: 0 PID: 0 at /home/yghannam/linux-amd-yazen/mm/early_ioremap.c:122 __early_ioremap+0x9b/0x1bd()
[  +0.000006] Modules linked in:
[  +0.000006] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.4.103-HEAD #2
...
[  +0.000006]  0000000000000286 02cb38f113d2874f ffffffff81e03e50 ffffffff813e0767
[  +0.000007]  0000000000000000 ffffffff81c9e5f0 ffffffff81e03e88 ffffffff81080192
[  +0.000007]  0000000074d32018 0000000000000000 0000000000000001 0000000000000001
[  +0.000007] Call Trace:
[  +0.000007]  [<ffffffff813e0767>] dump_stack+0x63/0x8c
[  +0.000006]  [<ffffffff81080192>] warn_slowpath_common+0x82/0xc0
[  +0.000005]  [<ffffffff810802da>] warn_slowpath_null+0x1a/0x20
[  +0.000004]  [<ffffffff81fbb86e>] __early_ioremap+0x9b/0x1bd
[  +0.000006]  [<ffffffff81fa5476>] ? __early_set_fixmap+0x84/0x95
[  +0.000005]  [<ffffffff811adc75>] ? kmalloc_slab+0x5/0xa0
[  +0.000005]  [<ffffffff81fbbb66>] early_ioremap+0x13/0x15
[  +0.000005]  [<ffffffff81fa860b>] efi_bgrt_init+0x192/0x1ea
[  +0.000004]  [<ffffffff81fa7b68>] efi_late_init+0x9/0xb
[  +0.000006]  [<ffffffff81f88002>] start_kernel+0x46c/0x49c
[  +0.000005]  [<ffffffff81f87120>] ? early_idt_handler_array+0x120/0x120
[  +0.000005]  [<ffffffff81f8732d>] x86_64_start_reservations+0x2a/0x2c
[  +0.000004]  [<ffffffff81f8746a>] x86_64_start_kernel+0x13b/0x15e
[  +0.000009] ---[ end trace f9b2fbcd6a135369 ]---
[  +0.000004] Ignoring BGRT: failed to map image memory

Stable version to apply to: 4.4.x

Thanks,
Yazen

Re: [PATCH] x86/efi-bgrt: Replace early_memremap() with memremap()

[Greg KH]

On Fri, Dec 01, 2017 at 08:35:52AM +0000, Ghannam, Yazen wrote:
> Upstream commit ID: e2c90dd7e11e3025b46719a79fb4bb1e7a5cef9f
> Prerequisite commit: "50a0cb565246 x86/efi-bgrt: Fix kernel panic when mapping BGRT data"

So apply both of these patches to 4.4?  Please be specific as I'm
confused here.

thanks,

greg k-h

RE: [PATCH] x86/efi-bgrt: Replace early_memremap() with memremap()

[Ghannam, Yazen]

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Friday, December 1, 2017 11:16 AM
> To: Ghannam, Yazen <Yazen.Ghannam@amd.com>
> Cc: stable@vger.kernel.org
> Subject: Re: [PATCH] x86/efi-bgrt: Replace early_memremap() with
> memremap()
> 
> On Fri, Dec 01, 2017 at 08:35:52AM +0000, Ghannam, Yazen wrote:
> > Upstream commit ID: e2c90dd7e11e3025b46719a79fb4bb1e7a5cef9f
> > Prerequisite commit: "50a0cb565246 x86/efi-bgrt: Fix kernel panic when
> mapping BGRT data"
> 
> So apply both of these patches to 4.4?  Please be specific as I'm
> confused here.
> 

Yes, both.

The first commit is the fix, and the second commit is needed for the first to
apply cleanly.

So cherry-pick
1) 50a0cb565246f20d59cdb161778531e4b19d35ac
2) e2c90dd7e11e3025b46719a79fb4bb1e7a5cef9f

Sorry, I wasn't sure of the best way to describe this.

Thanks,
Yazen

Re: [PATCH] x86/efi-bgrt: Replace early_memremap() with memremap()

[Greg KH]

On Fri, Dec 01, 2017 at 04:25:44PM +0000, Ghannam, Yazen wrote:
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Friday, December 1, 2017 11:16 AM
> > To: Ghannam, Yazen <Yazen.Ghannam@amd.com>
> > Cc: stable@vger.kernel.org
> > Subject: Re: [PATCH] x86/efi-bgrt: Replace early_memremap() with
> > memremap()
> > 
> > On Fri, Dec 01, 2017 at 08:35:52AM +0000, Ghannam, Yazen wrote:
> > > Upstream commit ID: e2c90dd7e11e3025b46719a79fb4bb1e7a5cef9f
> > > Prerequisite commit: "50a0cb565246 x86/efi-bgrt: Fix kernel panic when
> > mapping BGRT data"
> > 
> > So apply both of these patches to 4.4?  Please be specific as I'm
> > confused here.
> > 
> 
> Yes, both.
> 
> The first commit is the fix, and the second commit is needed for the first to
> apply cleanly.
> 
> So cherry-pick
> 1) 50a0cb565246f20d59cdb161778531e4b19d35ac
> 2) e2c90dd7e11e3025b46719a79fb4bb1e7a5cef9f
> 
> Sorry, I wasn't sure of the best way to describe this.

Both now applied, thanks.

greg k-h