stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: chris@chris-wilson.co.uk, jani.nikula@intel.com,
	rodrigo.vivi@intel.com, stable@vger.kernel.org
Subject: Re: WTF: patch "[PATCH] drm/i915: Fix init_clock_gating for resume" was seriously submitted to be applied to the 4.14-stable tree?
Date: Mon, 4 Dec 2017 14:13:00 +0100	[thread overview]
Message-ID: <20171204131300.GA5278@kroah.com> (raw)
In-Reply-To: <20171204125431.GQ10981@intel.com>

On Mon, Dec 04, 2017 at 02:54:31PM +0200, Ville Syrj�l� wrote:
> On Mon, Dec 04, 2017 at 01:36:08PM +0100, gregkh@linuxfoundation.org wrote:
> > The patch below was submitted to be applied to the 4.14-stable tree.
> > 
> > I fail to see how this patch meets the stable kernel rules as found at
> > Documentation/process/stable-kernel-rules.rst.
> 
> It fixes a regression. Why do you think it's not suitable for stable?

Because:

> > I could be totally wrong, and if so, please respond to 
> > <stable@vger.kernel.org> and let me know why this patch should be
> > applied.  Otherwise, it is now dropped from my patch queues, never to be
> > seen again.
> > 
> > thanks,
> > 
> > greg k-h
> > 
> > ------------------ original commit in Linus's tree ------------------
> > 
> > >From 3572f04c69ed4369da5d3c65d84fb18774aa60b6 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= <ville.syrjala@linux.intel.com>
> > Date: Thu, 16 Nov 2017 18:02:15 +0200
> > Subject: [PATCH] drm/i915: Fix init_clock_gating for resume
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> > 
> > Moving the init_clock_gating() call from intel_modeset_init_hw() to
> > intel_modeset_gem_init() had an unintended effect of not applying
> > some workarounds on resume. This, for example, cause some kind of
> > corruption to appear at the top of my IVB Thinkpad X1 Carbon LVDS
> > screen after hibernation. Fix the problem by explicitly calling
> > init_clock_gating() from the resume path.
> > 
> > I really hope this doesn't break something else again. At least
> > the problems reported at https://bugs.freedesktop.org/show_bug.cgi?id=103549
> > didn't make a comeback, even after a hibernate cycle.
> > 
> > v2: Reorder the init_clock_gating vs. modeset_init_hw to match
> >     the display reset path (Rodrigo)
> > 
> > Cc: stable@vger.kernel.org
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Fixes: 6ac43272768c ("drm/i915: Move init_clock_gating() back to where it was")

$ git describe --contains 6ac43272768c
v4.15-rc1~19^2~13^2~1

How is this a 4.14 regression?

thanks,

greg k-h

  reply	other threads:[~2017-12-04 13:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-04 12:36 WTF: patch "[PATCH] drm/i915: Fix init_clock_gating for resume" was seriously submitted to be applied to the 4.14-stable tree? gregkh
2017-12-04 12:54 ` Ville Syrjälä
2017-12-04 13:13   ` Greg KH [this message]
2017-12-04 13:41     ` Ville Syrjälä
2017-12-04 13:47       ` Greg KH
2017-12-04 18:45         ` Rodrigo Vivi
2017-12-04 19:07           ` Greg KH
2017-12-04 19:18             ` Daniel Vetter
2017-12-04 19:52               ` Greg KH
2017-12-04 23:17             ` Rodrigo Vivi
2018-01-11 19:42 ` [PATCH stable-4.14 1/2] drm/i915: Move init_clock_gating() back to where it was Ville Syrjala
2018-01-11 19:42   ` [PATCH stable-4.14 2/2] drm/i915: Fix init_clock_gating for resume Ville Syrjala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171204131300.GA5278@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=jani.nikula@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).