From: Greg KH <gregkh@linuxfoundation.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Andy Lutomirski <luto@kernel.org>,
Borislav Petkov <bpetkov@suse.de>,
Brian Gerst <brgerst@gmail.com>,
Dave Hansen <dave.hansen@intel.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
stable <stable@vger.kernel.org>,
stable-commits@vger.kernel.org
Subject: Re: Patch "x86/entry/64: Add missing irqflags tracing to native_load_gs_index()" has been added to the 4.9-stable tree
Date: Mon, 4 Dec 2017 15:01:46 +0100 [thread overview]
Message-ID: <20171204140146.GB8744@kroah.com> (raw)
In-Reply-To: <8F07AA65-5620-4B6C-B077-1F291984A587@amacapital.net>
On Mon, Dec 04, 2017 at 05:52:55AM -0800, Andy Lutomirski wrote:
>
>
> > On Dec 4, 2017, at 4:02 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> >> On Thu, Nov 30, 2017 at 10:50:22AM -0800, Andy Lutomirski wrote:
> >>> On Thu, Nov 30, 2017 at 6:29 AM, Andy Lutomirski <luto@amacapital.net> wrote:
> >>>
> >>>
> >>>>> On Nov 30, 2017, at 12:44 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >>>>>
> >>>>> On Wed, Nov 29, 2017 at 08:23:10AM -0800, Andy Lutomirski wrote:
> >>>>> If this hasn't been released yet, please hold off. It's buggy.
> >>>>
> >>>> Ah crap, I missed this and just released it. Is there a fix for this in
> >>>> Linus's tree? How "buggy" is it?
> >>>
> >>> It breaks suspend/resume on some configuration that I haven't quite figured out. I think it only happens if (lockdep is on and some other unknown condition occurs) or (ftrace is actively tracing irq flags). I have a fix, but I was waiting to for the OP to test it.
> >>>
> >>> I'll send the fix Linusward later today without the Tested-by if I don't hear anything.
> >>
> >> I think the thing to do is to revert the patch from -stable. The bug
> >> it fixes is very minor, and the regression is that it made a
> >> pre-existing bug in some nearly-undebuggable core resume code much
> >> easier to hit. I don't feel comfortable with a backport of the latter
> >> fix until it has a good long soak in Linus' tree.
> >
> > Ok, now reverted. Should I do the same thing for the patch in
> > 4.14-stable as well?
>
> Yes please.
Great, now done.
greg k-h
prev parent reply other threads:[~2017-12-04 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 12:41 Patch "x86/entry/64: Add missing irqflags tracing to native_load_gs_index()" has been added to the 4.9-stable tree gregkh
2017-11-29 16:23 ` Andy Lutomirski
2017-11-30 8:44 ` Greg KH
2017-11-30 14:29 ` Andy Lutomirski
2017-11-30 18:50 ` Andy Lutomirski
2017-12-04 12:02 ` Greg KH
2017-12-04 13:52 ` Andy Lutomirski
2017-12-04 14:01 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204140146.GB8744@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bpetkov@suse.de \
--cc=brgerst@gmail.com \
--cc=dave.hansen@intel.com \
--cc=jpoimboe@redhat.com \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).