From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f52.google.com ([209.85.215.52]:46269 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbdLKK3y (ORCPT ); Mon, 11 Dec 2017 05:29:54 -0500 Date: Mon, 11 Dec 2017 11:29:55 +0100 From: Johan Hovold To: Murali Karicheri , Lorenzo Pieralisi , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold , stable Subject: Re: [PATCH v2] PCI: keystone: fix interrupt-controller-node lookup Message-ID: <20171211102955.GK5672@localhost> References: <20171117133831.1300-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171117133831.1300-1-johan@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Nov 17, 2017 at 02:38:31PM +0100, Johan Hovold wrote: > Fix child-node lookup during initialisation which was using the wrong > OF-helper and ended up searching the whole device tree depth-first > starting at the parent rather than just matching on its children. > > To make things worse, the parent pci node could end up being prematurely > freed as of_find_node_by_name() drops a reference to its first argument. > Any matching child interrupt-controller node was also leaked. > > Fixes: 0c4ffcfe1fbc ("PCI: keystone: Add TI Keystone PCIe driver") > Cc: stable # 3.18 > Acked-by: Murali Karicheri > Acked-by: Lorenzo Pieralisi > Signed-off-by: Johan Hovold > --- > > v2 > - amend commit message and mention explicitly that of_find_node_by_name() > drops a reference to the start node > - add Murali's and Lorenzo's acks This one hasn't shown up in linux-next, so sending a reminder to make sure it doesn't fall between the cracks. Thanks, Johan