From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org ([198.145.29.96]:56868 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934152AbdLRVHL (ORCPT ); Mon, 18 Dec 2017 16:07:11 -0500 Date: Mon, 18 Dec 2017 13:07:09 -0800 From: Stephen Boyd To: Chen-Yu Tsai Cc: Maxime Ripard , Michael Turquette , Philipp Zabel , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH] clk: sunxi: sun9i-mmc: Implement reset callback for reset controls Message-ID: <20171218210709.GY7997@codeaurora.org> References: <20171218035751.20661-1-wens@csie.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171218035751.20661-1-wens@csie.org> Sender: stable-owner@vger.kernel.org List-ID: On 12/18, Chen-Yu Tsai wrote: > Our MMC host driver now issues a reset, instead of just deasserting > the reset control, since commit c34eda69ad4c ("mmc: sunxi: Reset the > device at probe time"). The sun9i-mmc clock driver does not support > this, and will fail, which results in MMC not probing. > > This patch implements the reset callback by asserting the reset control, > then deasserting it after a small delay. > > Fixes: 7a6fca879f59 ("clk: sunxi: Add driver for A80 MMC config clocks/resets") > Cc: # 4.14.x > Signed-off-by: Chen-Yu Tsai > --- Did you want us to pick this up into clk-fixes? It seems to be causing MMC to not work for some time? That sounds annoying enough. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project