* [PATCH v4 05/15] drm/sun4i: Fix error path handling [not found] <cover.e46a07c0e181d735c807dc94fe0ce0ea013788be.1512662253.git-series.maxime.ripard@free-electrons.com> @ 2017-12-07 15:58 ` Maxime Ripard 2017-12-19 8:59 ` Maxime Ripard 0 siblings, 1 reply; 2+ messages in thread From: Maxime Ripard @ 2017-12-07 15:58 UTC (permalink / raw) To: Daniel Vetter, David Airlie, Chen-Yu Tsai, Maxime Ripard Cc: dri-devel, linux-kernel, Mark Rutland, Rob Herring, linux-arm-kernel, plaes, icenowy, Thomas Petazzoni, jernej.skrabec, devicetree, thierry.reding, stable The commit 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap initialization sequence") moved a bunch of logic around, but forgot to update the gotos after the introduction of the err_free_dotclock label. It means that if we fail later that the one introduced in that commit, we'll just to the old label which isn't free the clock we created. This will result in a breakage as soon as someone tries to do something with that clock, since its resources will have been long reclaimed. Cc: <stable@vger.kernel.org> Fixes: 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap initialization sequence") Reviewed-by: Chen-Yu Tsai <wens@csie.org> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index a1ed462c2430..ea056a3d2131 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c @@ -724,12 +724,12 @@ static int sun4i_tcon_bind(struct device *dev, struct device *master, if (IS_ERR(tcon->crtc)) { dev_err(dev, "Couldn't create our CRTC\n"); ret = PTR_ERR(tcon->crtc); - goto err_free_clocks; + goto err_free_dotclock; } ret = sun4i_rgb_init(drm, tcon); if (ret < 0) - goto err_free_clocks; + goto err_free_dotclock; if (tcon->quirks->needs_de_be_mux) { /* -- git-series 0.9.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4 05/15] drm/sun4i: Fix error path handling 2017-12-07 15:58 ` [PATCH v4 05/15] drm/sun4i: Fix error path handling Maxime Ripard @ 2017-12-19 8:59 ` Maxime Ripard 0 siblings, 0 replies; 2+ messages in thread From: Maxime Ripard @ 2017-12-19 8:59 UTC (permalink / raw) To: Daniel Vetter, David Airlie, Chen-Yu Tsai Cc: dri-devel, linux-kernel, Mark Rutland, Rob Herring, linux-arm-kernel, plaes, icenowy, Thomas Petazzoni, jernej.skrabec, devicetree, thierry.reding, stable [-- Attachment #1: Type: text/plain, Size: 951 bytes --] On Thu, Dec 07, 2017 at 04:58:50PM +0100, Maxime Ripard wrote: > The commit 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap > initialization sequence") moved a bunch of logic around, but forgot to > update the gotos after the introduction of the err_free_dotclock label. > > It means that if we fail later that the one introduced in that commit, > we'll just to the old label which isn't free the clock we created. This > will result in a breakage as soon as someone tries to do something with > that clock, since its resources will have been long reclaimed. > > Cc: <stable@vger.kernel.org> > Fixes: 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap initialization sequence") > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Applied this one as a fix. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-19 9:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.e46a07c0e181d735c807dc94fe0ce0ea013788be.1512662253.git-series.maxime.ripard@free-electrons.com>
2017-12-07 15:58 ` [PATCH v4 05/15] drm/sun4i: Fix error path handling Maxime Ripard
2017-12-19 8:59 ` Maxime Ripard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).