From: Greg KH <gregkh@linuxfoundation.org>
To: Thiago Rafael Becker <thiago.becker@gmail.com>
Cc: stable@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] kernel: make groups_sort calling a responsibility group_info allocators
Date: Wed, 20 Dec 2017 18:05:22 +0100 [thread overview]
Message-ID: <20171220170522.GC31793@kroah.com> (raw)
In-Reply-To: <20171219010220.12313-1-thiago.becker@gmail.com>
On Mon, Dec 18, 2017 at 11:02:20PM -0200, Thiago Rafael Becker wrote:
> In testing, we found that nfsd threads may call set_groups in parallel
> for the same entry cached in auth.unix.gid, racing in the call of
> groups_sort, corrupting the groups for that entry and leading to
> permission denials for the client.
>
> This patch:
> - Make groups_sort globally visible.
> - Move the call to groups_sort to the modifiers of group_info
> - Remove the call to groups_sort from set_groups
>
> Link: http://lkml.kernel.org/r/20171211151420.18655-1-thiago.becker@gmail.com
> (backported from bdcf0a423ea1c40bbb40e7ee483b50fc8aa3d758)
> Signed-off-by: Thiago Rafael Becker <thiago.becker@gmail.com>
> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
> Reviewed-by: NeilBrown <neilb@suse.com>
> Acked-by: "J. Bruce Fields" <bfields@fieldses.org>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> ---
Any hint as to what kernel tree(s) this backport is for?
thanks,
greg k-h
next prev parent reply other threads:[~2017-12-20 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 11:36 FAILED: patch "[PATCH] kernel: make groups_sort calling a responsibility group_info" failed to apply to 4.4-stable tree gregkh
2017-12-19 1:02 ` [PATCH] kernel: make groups_sort calling a responsibility group_info allocators Thiago Rafael Becker
2017-12-20 17:05 ` Greg KH [this message]
2018-01-03 22:21 ` [PATCH - 4.4-stable backport] " NeilBrown
2018-01-05 22:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220170522.GC31793@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=schwidefsky@de.ibm.com \
--cc=stable@vger.kernel.org \
--cc=thiago.becker@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).