From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:33630 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754388AbdLTRFU (ORCPT ); Wed, 20 Dec 2017 12:05:20 -0500 Date: Wed, 20 Dec 2017 18:05:22 +0100 From: Greg KH To: Thiago Rafael Becker Cc: stable@vger.kernel.org, Al Viro , Martin Schwidefsky , Andrew Morton , Linus Torvalds Subject: Re: [PATCH] kernel: make groups_sort calling a responsibility group_info allocators Message-ID: <20171220170522.GC31793@kroah.com> References: <1513596999178204@kroah.com> <20171219010220.12313-1-thiago.becker@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171219010220.12313-1-thiago.becker@gmail.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Dec 18, 2017 at 11:02:20PM -0200, Thiago Rafael Becker wrote: > In testing, we found that nfsd threads may call set_groups in parallel > for the same entry cached in auth.unix.gid, racing in the call of > groups_sort, corrupting the groups for that entry and leading to > permission denials for the client. > > This patch: > - Make groups_sort globally visible. > - Move the call to groups_sort to the modifiers of group_info > - Remove the call to groups_sort from set_groups > > Link: http://lkml.kernel.org/r/20171211151420.18655-1-thiago.becker@gmail.com > (backported from bdcf0a423ea1c40bbb40e7ee483b50fc8aa3d758) > Signed-off-by: Thiago Rafael Becker > Reviewed-by: Matthew Wilcox > Reviewed-by: NeilBrown > Acked-by: "J. Bruce Fields" > Cc: Al Viro > Cc: Martin Schwidefsky > Cc: > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds > --- Any hint as to what kernel tree(s) this backport is for? thanks, greg k-h