From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:36144 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754388AbdLTRNR (ORCPT ); Wed, 20 Dec 2017 12:13:17 -0500 Date: Wed, 20 Dec 2017 18:13:19 +0100 From: Greg KH To: alexander.levin@verizon.com Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Masahiro Yamada Subject: Re: [PATCH AUTOSEL for 4.14 20/60] kbuild: re-order the code to not parse unnecessary variables Message-ID: <20171220171319.GA6541@kroah.com> References: <20171213015455.6455-1-alexander.levin@verizon.com> <20171213015455.6455-20-alexander.levin@verizon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213015455.6455-20-alexander.levin@verizon.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Dec 13, 2017 at 01:55:15AM +0000, alexander.levin@verizon.com wrote: > From: Masahiro Yamada > > [ Upstream commit 2c1f4f125159f10521944cea23e33a00fcf85ede ] > > The top Makefile is divided into some sections such as mixed targets, > config targets, build targets, etc. > > When we build mixed targets, Kbuild just invokes submake to process > them one by one. In this case, compiler-related variables like CC, > KBUILD_CFLAGS, etc. are unneeded. > > Check what kind of targets we are building first, and parse variables > for building only when necessary. > > Signed-off-by: Masahiro Yamada > Signed-off-by: Sasha Levin > --- > Makefile | 233 ++++++++++++++++++++++++++++++++------------------------------- > 1 file changed, 118 insertions(+), 115 deletions(-) While this is a "nice thing", I don't see how this is a good 4.14-stable patch. It doesn't fix a bug, is really "big", and might make a build faster (but does it even do that?) So I'm going to drop this from the pull request you sent, thanks. greg k-h