From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com ([66.111.4.27]:43887 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbdLUJyb (ORCPT ); Thu, 21 Dec 2017 04:54:31 -0500 Date: Thu, 21 Dec 2017 10:54:34 +0100 From: Greg KH To: alexander.levin@verizon.com Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Hoang Tran , Hoang Tran , "David S . Miller" Subject: Re: [PATCH AUTOSEL for 3.18 40/40] tcp: fix under-evaluated ssthresh in TCP Vegas Message-ID: <20171221095434.GA3342@kroah.com> References: <20171213015905.7059-1-alexander.levin@verizon.com> <20171213015905.7059-40-alexander.levin@verizon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213015905.7059-40-alexander.levin@verizon.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Dec 13, 2017 at 01:59:21AM +0000, alexander.levin@verizon.com wrote: > From: Hoang Tran > > [ Upstream commit cf5d74b85ef40c202c76d90959db4d850f301b95 ] > > With the commit 76174004a0f19785 (tcp: do not slow start when cwnd equals > ssthresh), the comparison to the reduced cwnd in tcp_vegas_ssthresh() would > under-evaluate the ssthresh. > > Signed-off-by: Hoang Tran > Signed-off-by: David S. Miller > Signed-off-by: Sasha Levin > --- > net/ipv4/tcp_vegas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) 76174004a0f19785 did not show up until 4.3-rc1, so this isn't needed for 3.18-stable, so I'm going to drop it from that set of patches. thanks, greg k-h > > diff --git a/net/ipv4/tcp_vegas.c b/net/ipv4/tcp_vegas.c > index a6afde666ab1..28b2728a06c4 100644 > --- a/net/ipv4/tcp_vegas.c > +++ b/net/ipv4/tcp_vegas.c > @@ -158,7 +158,7 @@ EXPORT_SYMBOL_GPL(tcp_vegas_cwnd_event); > > static inline u32 tcp_vegas_ssthresh(struct tcp_sock *tp) > { > - return min(tp->snd_ssthresh, tp->snd_cwnd-1); > + return min(tp->snd_ssthresh, tp->snd_cwnd); > } > > static void tcp_vegas_cong_avoid(struct sock *sk, u32 ack, u32 acked) > -- > 2.11.0