From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:36144 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751253AbdL0Msl (ORCPT ); Wed, 27 Dec 2017 07:48:41 -0500 Date: Wed, 27 Dec 2017 13:48:44 +0100 From: Greg Kroah-Hartman To: Ben Hutchings Cc: Andi Kleen , inux-kernel@vger.kernel.org, stable@vger.kernel.org, Thomas Gleixner , Linus Torvalds , Peter Zijlstra , Ingo Molnar Subject: Re: [PATCH 4.14 015/159] bitops: Add clear/set_bit32() to linux/bitops.h Message-ID: <20171227124844.GD3373@kroah.com> References: <20171222084623.668990192@linuxfoundation.org> <20171222084624.604335610@linuxfoundation.org> <1514324496.2714.69.camel@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1514324496.2714.69.camel@decadent.org.uk> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Dec 26, 2017 at 09:41:36PM +0000, Ben Hutchings wrote: > On Fri, 2017-12-22 at 09:45 +0100, Greg Kroah-Hartman wrote: > > 4.14-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Andi Kleen > > > > commit cbe96375025e14fc76f9ed42ee5225120d7210f8 upstream. > > > > Add two simple wrappers around set_bit/clear_bit() that accept > > the common case of an u32 array. This avoids writing > > casts in all callers. > > These won't work correctly on big-endian 64-bit systems. They are also > unsafe to use on u32 arrays with an odd length, on 64-bit systems. > This is why lib/bitmap.c has conversion functions for u32 arrays. I end up deleteing these later in the patch series, just like upstream did, so all should be ok, right? thanks, greg k-h