From: Greg KH <greg@kroah.com>
To: minyard@acm.org
Cc: stable@vger.kernel.org, Corey Minyard <cminyard@mvista.com>,
Sasha Levin <alexander.levin@verizon.com>
Subject: Re: [PATCH] Revert "ipmi_si: fix memory leak on new_smi"
Date: Wed, 27 Dec 2017 16:50:44 +0100 [thread overview]
Message-ID: <20171227155044.GA9872@kroah.com> (raw)
In-Reply-To: <1514389304-27870-1-git-send-email-minyard@acm.org>
On Wed, Dec 27, 2017 at 09:41:44AM -0600, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> This reverts commit c97e41076a298dbc4e910c33048e553658388eed.
>
> A backport was requested of c0a32fe13cd32 "ipmi_si: fix memory leak on
> new_smi", but the backport shouldn't have been done. This change needs
> to be reverted, as it can result in an oops and the previous code is
> correct.
>
> Reverts: c97e41076a29 ("ipmi_si: fix memory leak on new_smi")
> Link: https://bbs.archlinux.org/viewtopic.php?pid=1757130#p1757130
> Reported-by: Neil Romig <neil@sixtythree.me.uk>
> Cc: Sasha Levin <alexander.levin@verizon.com>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> ---
>
> This is for 4.14 stable tree only. In hindsight, I should scrutinize
> stable kernel requests from others in the IPMI tree. Sorry about that.
I just queued this patch up from someone else already. Thanks for it,
and sorry for the problems.
greg k-h
>
> drivers/char/ipmi/ipmi_si_intf.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index e1cbb78..c04aa11 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -3469,7 +3469,6 @@ static int add_smi(struct smi_info *new_smi)
> ipmi_addr_src_to_str(new_smi->addr_source),
> si_to_str[new_smi->si_type]);
> rv = -EBUSY;
> - kfree(new_smi);
> goto out_err;
> }
> }
> --
> 2.7.4
next prev parent reply other threads:[~2017-12-27 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 15:41 [PATCH] Revert "ipmi_si: fix memory leak on new_smi" minyard
2017-12-27 15:50 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-23 23:03 John Einar Reitan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227155044.GA9872@kroah.com \
--to=greg@kroah.com \
--cc=alexander.levin@verizon.com \
--cc=cminyard@mvista.com \
--cc=minyard@acm.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).