From: Jason Gunthorpe <jgg@ziepe.ca>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 05/28] IB/srpt: Disable RDMA access by the initiator
Date: Wed, 3 Jan 2018 20:12:02 -0700 [thread overview]
Message-ID: <20180104031202.GA20938@ziepe.ca> (raw)
In-Reply-To: <20180103213938.11664-6-bart.vanassche@wdc.com>
On Wed, Jan 03, 2018 at 01:39:15PM -0800, Bart Van Assche wrote:
> With the SRP protocol all RDMA operations are initiated by the target.
> Since no RDMA operations are initiated by the initiator, do not grant
> the initiator permission to submit RDMA reads or writes to the target.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
> Cc: <stable@vger.kernel.org>
> drivers/infiniband/ulp/srpt/ib_srpt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index 8a1bd354b1cc..7c4249038004 100644
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -1013,8 +1013,7 @@ static int srpt_init_ch_qp(struct srpt_rdma_ch *ch, struct ib_qp *qp)
> return -ENOMEM;
>
> attr->qp_state = IB_QPS_INIT;
> - attr->qp_access_flags = IB_ACCESS_LOCAL_WRITE | IB_ACCESS_REMOTE_READ |
> - IB_ACCESS_REMOTE_WRITE;
> + attr->qp_access_flags = IB_ACCESS_LOCAL_WRITE;
> attr->port_num = ch->sport->port;
> attr->pkey_index = 0;
Applied to for-rc thanks
Jason
next prev parent reply other threads:[~2018-01-04 3:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180103213938.11664-1-bart.vanassche@wdc.com>
2018-01-03 21:39 ` [PATCH 05/28] IB/srpt: Disable RDMA access by the initiator Bart Van Assche
2018-01-04 3:12 ` Jason Gunthorpe [this message]
2018-01-03 21:39 ` [PATCH 06/28] IB/srpt: Fix ACL lookup during login Bart Van Assche
2018-01-04 3:12 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104031202.GA20938@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bart.vanassche@wdc.com \
--cc=dledford@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).