* Re: stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b)
[not found] <5a535545.93b5df0a.a7ca3.53c1@mx.google.com>
@ 2018-01-08 13:16 ` Arnd Bergmann
2018-01-08 13:35 ` Boris Brezillon
2018-01-08 13:44 ` gregkh
0 siblings, 2 replies; 6+ messages in thread
From: Arnd Bergmann @ 2018-01-08 13:16 UTC (permalink / raw)
To: kernelci.org bot
Cc: Kernel Build Reports Mailman List, Boris Brezillon,
Sean Nyekjær, Willy Tarreau, Ezequiel Garcia, Robert Jarzmik,
Richard Weinberger, linux-mtd, Linux Kernel Mailing List, # 4.4.x,
gregkh
On Mon, Jan 8, 2018 at 12:25 PM, kernelci.org bot <bot@kernelci.org> wrote:
>
> stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b)
> Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.110-18-g5da3d9af3a4b/
> Tree: stable-rc
> Branch: linux-4.4.y
> Git Describe: v4.4.110-18-g5da3d9af3a4b
> Git Commit: 5da3d9af3a4b90d3c5ab19f9ad1dbb7d237edcf9
> Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> Built: 4 unique architectures
>
> Build Failures Detected:
>
> arm: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05)
> cm_x300_defconfig FAIL
> mvebu_v7_defconfig FAIL
> pxa3xx_defconfig FAIL
> raumfeld_defconfig FAIL
>
> mvebu_v7_defconfig (arm) — FAIL, 2 errors, 0 warnings, 0 section mismatches
>
> Errors:
> drivers/mtd/nand/pxa3xx_nand.c:918:2: error: duplicate case value
> drivers/mtd/nand/pxa3xx_nand.c:915:2: error: previously used here
Hi Greg,
Commit fee4380f368e ("mtd: nand: pxa3xx: Fix READOOB implementation") was
apparently backported in error, it looks like it should just be
dropped here in 4.4.y.
The commit lists 'Fixes: 43bcfd2bb24a ("mtd: nand: pxa3xx: Add driver-specific
ECC BCH support")', that commit was merged into v4.14, so backporting the
fix further is probably not appropriate for 4.9 or earlier kernels either.
The duplicate case statement only happens before linux-4.6, as commit
c2cdace755b5 ("mtd: nand: pxa3xx_nand: add support for partial chunks")'
removed a previous 'case READOOB' statement in this driver, so the build
regression appears only in 4.4 but not 4.9.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b)
2018-01-08 13:16 ` stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b) Arnd Bergmann
@ 2018-01-08 13:35 ` Boris Brezillon
2018-01-08 13:44 ` gregkh
1 sibling, 0 replies; 6+ messages in thread
From: Boris Brezillon @ 2018-01-08 13:35 UTC (permalink / raw)
To: Arnd Bergmann
Cc: kernelci.org bot, Kernel Build Reports Mailman List,
Sean Nyekjær, Willy Tarreau, Ezequiel Garcia, Robert Jarzmik,
Richard Weinberger, linux-mtd, Linux Kernel Mailing List, # 4.4.x,
gregkh
Hi Arnd,
On Mon, 8 Jan 2018 14:16:25 +0100
Arnd Bergmann <arnd@arndb.de> wrote:
> On Mon, Jan 8, 2018 at 12:25 PM, kernelci.org bot <bot@kernelci.org> wrote:
> >
> > stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b)
> > Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.110-18-g5da3d9af3a4b/
> > Tree: stable-rc
> > Branch: linux-4.4.y
> > Git Describe: v4.4.110-18-g5da3d9af3a4b
> > Git Commit: 5da3d9af3a4b90d3c5ab19f9ad1dbb7d237edcf9
> > Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > Built: 4 unique architectures
> >
> > Build Failures Detected:
> >
> > arm: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05)
> > cm_x300_defconfig FAIL
> > mvebu_v7_defconfig FAIL
> > pxa3xx_defconfig FAIL
> > raumfeld_defconfig FAIL
> >
> > mvebu_v7_defconfig (arm) — FAIL, 2 errors, 0 warnings, 0 section mismatches
> >
> > Errors:
> > drivers/mtd/nand/pxa3xx_nand.c:918:2: error: duplicate case value
> > drivers/mtd/nand/pxa3xx_nand.c:915:2: error: previously used here
>
> Hi Greg,
>
> Commit fee4380f368e ("mtd: nand: pxa3xx: Fix READOOB implementation") was
> apparently backported in error, it looks like it should just be
> dropped here in 4.4.y.
>
> The commit lists 'Fixes: 43bcfd2bb24a ("mtd: nand: pxa3xx: Add driver-specific
> ECC BCH support")', that commit was merged into v4.14,
git tag --contains says commit 43bcfd2bb24a has been merged in 3.14.
> so backporting the
> fix further is probably not appropriate for 4.9 or earlier kernels either.
>
> The duplicate case statement only happens before linux-4.6, as commit
> c2cdace755b5 ("mtd: nand: pxa3xx_nand: add support for partial chunks")'
> removed a previous 'case READOOB' statement in this driver, so the build
> regression appears only in 4.4 but not 4.9.
Crap, I didn't notice the NAND_READOOB case was handled before 4.6.
Still, the fix is needed, which means we'll have to revert this version
and create a custom one for 4.4.
Thanks for this report.
Boris
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b)
2018-01-08 13:16 ` stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b) Arnd Bergmann
2018-01-08 13:35 ` Boris Brezillon
@ 2018-01-08 13:44 ` gregkh
2018-01-08 14:01 ` Arnd Bergmann
1 sibling, 1 reply; 6+ messages in thread
From: gregkh @ 2018-01-08 13:44 UTC (permalink / raw)
To: Arnd Bergmann
Cc: kernelci.org bot, Kernel Build Reports Mailman List,
Boris Brezillon, Sean Nyekjær, Willy Tarreau,
Ezequiel Garcia, Robert Jarzmik, Richard Weinberger, linux-mtd,
Linux Kernel Mailing List, # 4.4.x
On Mon, Jan 08, 2018 at 02:16:25PM +0100, Arnd Bergmann wrote:
> On Mon, Jan 8, 2018 at 12:25 PM, kernelci.org bot <bot@kernelci.org> wrote:
> >
> > stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b)
> > Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.110-18-g5da3d9af3a4b/
> > Tree: stable-rc
> > Branch: linux-4.4.y
> > Git Describe: v4.4.110-18-g5da3d9af3a4b
> > Git Commit: 5da3d9af3a4b90d3c5ab19f9ad1dbb7d237edcf9
> > Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > Built: 4 unique architectures
> >
> > Build Failures Detected:
> >
> > arm: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05)
> > cm_x300_defconfig FAIL
> > mvebu_v7_defconfig FAIL
> > pxa3xx_defconfig FAIL
> > raumfeld_defconfig FAIL
> >
> > mvebu_v7_defconfig (arm) — FAIL, 2 errors, 0 warnings, 0 section mismatches
> >
> > Errors:
> > drivers/mtd/nand/pxa3xx_nand.c:918:2: error: duplicate case value
> > drivers/mtd/nand/pxa3xx_nand.c:915:2: error: previously used here
>
> Hi Greg,
>
> Commit fee4380f368e ("mtd: nand: pxa3xx: Fix READOOB implementation") was
> apparently backported in error, it looks like it should just be
> dropped here in 4.4.y.
>
> The commit lists 'Fixes: 43bcfd2bb24a ("mtd: nand: pxa3xx: Add driver-specific
> ECC BCH support")', that commit was merged into v4.14, so backporting the
> fix further is probably not appropriate for 4.9 or earlier kernels either.
$ git describe --contains 43bcfd2bb24a
v3.14-rc1~65^2~127
That is why I backported these patches this far.
I'll drop the patch now, but the Fixes line is the problem here :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b)
2018-01-08 13:44 ` gregkh
@ 2018-01-08 14:01 ` Arnd Bergmann
2018-01-08 15:30 ` Boris Brezillon
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2018-01-08 14:01 UTC (permalink / raw)
To: gregkh
Cc: kernelci.org bot, Kernel Build Reports Mailman List,
Boris Brezillon, Sean Nyekjær, Willy Tarreau,
Ezequiel Garcia, Robert Jarzmik, Richard Weinberger, linux-mtd,
Linux Kernel Mailing List, # 4.4.x
On Mon, Jan 8, 2018 at 2:44 PM, gregkh <gregkh@linuxfoundation.org> wrote:
> On Mon, Jan 08, 2018 at 02:16:25PM +0100, Arnd Bergmann wrote:
>> On Mon, Jan 8, 2018 at 12:25 PM, kernelci.org bot <bot@kernelci.org> wrote:
>> >
>> > stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b)
>> > Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.110-18-g5da3d9af3a4b/
>> > Tree: stable-rc
>> > Branch: linux-4.4.y
>> > Git Describe: v4.4.110-18-g5da3d9af3a4b
>> > Git Commit: 5da3d9af3a4b90d3c5ab19f9ad1dbb7d237edcf9
>> > Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
>> > Built: 4 unique architectures
>> >
>> > Build Failures Detected:
>> >
>> > arm: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05)
>> > cm_x300_defconfig FAIL
>> > mvebu_v7_defconfig FAIL
>> > pxa3xx_defconfig FAIL
>> > raumfeld_defconfig FAIL
>> >
>> > mvebu_v7_defconfig (arm) — FAIL, 2 errors, 0 warnings, 0 section mismatches
>> >
>> > Errors:
>> > drivers/mtd/nand/pxa3xx_nand.c:918:2: error: duplicate case value
>> > drivers/mtd/nand/pxa3xx_nand.c:915:2: error: previously used here
>>
>> Hi Greg,
>>
>> Commit fee4380f368e ("mtd: nand: pxa3xx: Fix READOOB implementation") was
>> apparently backported in error, it looks like it should just be
>> dropped here in 4.4.y.
>>
>> The commit lists 'Fixes: 43bcfd2bb24a ("mtd: nand: pxa3xx: Add driver-specific
>> ECC BCH support")', that commit was merged into v4.14, so backporting the
>> fix further is probably not appropriate for 4.9 or earlier kernels either.
>
> $ git describe --contains 43bcfd2bb24a
> v3.14-rc1~65^2~127
>
> That is why I backported these patches this far.
>
> I'll drop the patch now, but the Fixes line is the problem here :)
I think my mistake in the report was misreading v3.14 as v4.14. That means we
still need the fix, just as Boris explained, it just needs to be done
differently
for older kernels.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b)
2018-01-08 14:01 ` Arnd Bergmann
@ 2018-01-08 15:30 ` Boris Brezillon
2018-01-08 16:34 ` gregkh
0 siblings, 1 reply; 6+ messages in thread
From: Boris Brezillon @ 2018-01-08 15:30 UTC (permalink / raw)
To: Arnd Bergmann
Cc: gregkh, kernelci.org bot, Kernel Build Reports Mailman List,
Sean Nyekjær, Willy Tarreau, Ezequiel Garcia, Robert Jarzmik,
Richard Weinberger, linux-mtd, Linux Kernel Mailing List, # 4.4.x
On Mon, 8 Jan 2018 15:01:38 +0100
Arnd Bergmann <arnd@arndb.de> wrote:
> On Mon, Jan 8, 2018 at 2:44 PM, gregkh <gregkh@linuxfoundation.org> wrote:
> > On Mon, Jan 08, 2018 at 02:16:25PM +0100, Arnd Bergmann wrote:
> >> On Mon, Jan 8, 2018 at 12:25 PM, kernelci.org bot <bot@kernelci.org> wrote:
> >> >
> >> > stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b)
> >> > Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.110-18-g5da3d9af3a4b/
> >> > Tree: stable-rc
> >> > Branch: linux-4.4.y
> >> > Git Describe: v4.4.110-18-g5da3d9af3a4b
> >> > Git Commit: 5da3d9af3a4b90d3c5ab19f9ad1dbb7d237edcf9
> >> > Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> >> > Built: 4 unique architectures
> >> >
> >> > Build Failures Detected:
> >> >
> >> > arm: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05)
> >> > cm_x300_defconfig FAIL
> >> > mvebu_v7_defconfig FAIL
> >> > pxa3xx_defconfig FAIL
> >> > raumfeld_defconfig FAIL
> >> >
> >> > mvebu_v7_defconfig (arm) — FAIL, 2 errors, 0 warnings, 0 section mismatches
> >> >
> >> > Errors:
> >> > drivers/mtd/nand/pxa3xx_nand.c:918:2: error: duplicate case value
> >> > drivers/mtd/nand/pxa3xx_nand.c:915:2: error: previously used here
> >>
> >> Hi Greg,
> >>
> >> Commit fee4380f368e ("mtd: nand: pxa3xx: Fix READOOB implementation") was
> >> apparently backported in error, it looks like it should just be
> >> dropped here in 4.4.y.
> >>
> >> The commit lists 'Fixes: 43bcfd2bb24a ("mtd: nand: pxa3xx: Add driver-specific
> >> ECC BCH support")', that commit was merged into v4.14, so backporting the
> >> fix further is probably not appropriate for 4.9 or earlier kernels either.
> >
> > $ git describe --contains 43bcfd2bb24a
> > v3.14-rc1~65^2~127
> >
> > That is why I backported these patches this far.
> >
> > I'll drop the patch now, but the Fixes line is the problem here :)
>
> I think my mistake in the report was misreading v3.14 as v4.14. That means we
> still need the fix, just as Boris explained, it just needs to be done
> differently
> for older kernels.
Hm, actually I was wrong with my Fixes tag, it seems the bug has been
introduced by 'c2cdace755b5 ("mtd: nand: pxa3xx_nand: add support for
partial chunks")', so the fix is not needed for pre-4.6 kernels.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b)
2018-01-08 15:30 ` Boris Brezillon
@ 2018-01-08 16:34 ` gregkh
0 siblings, 0 replies; 6+ messages in thread
From: gregkh @ 2018-01-08 16:34 UTC (permalink / raw)
To: Boris Brezillon
Cc: Arnd Bergmann, kernelci.org bot,
Kernel Build Reports Mailman List, Sean Nyekjær,
Willy Tarreau, Ezequiel Garcia, Robert Jarzmik,
Richard Weinberger, linux-mtd, Linux Kernel Mailing List, # 4.4.x
On Mon, Jan 08, 2018 at 04:30:29PM +0100, Boris Brezillon wrote:
> On Mon, 8 Jan 2018 15:01:38 +0100
> Arnd Bergmann <arnd@arndb.de> wrote:
>
> > On Mon, Jan 8, 2018 at 2:44 PM, gregkh <gregkh@linuxfoundation.org> wrote:
> > > On Mon, Jan 08, 2018 at 02:16:25PM +0100, Arnd Bergmann wrote:
> > >> On Mon, Jan 8, 2018 at 12:25 PM, kernelci.org bot <bot@kernelci.org> wrote:
> > >> >
> > >> > stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b)
> > >> > Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.110-18-g5da3d9af3a4b/
> > >> > Tree: stable-rc
> > >> > Branch: linux-4.4.y
> > >> > Git Describe: v4.4.110-18-g5da3d9af3a4b
> > >> > Git Commit: 5da3d9af3a4b90d3c5ab19f9ad1dbb7d237edcf9
> > >> > Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > >> > Built: 4 unique architectures
> > >> >
> > >> > Build Failures Detected:
> > >> >
> > >> > arm: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05)
> > >> > cm_x300_defconfig FAIL
> > >> > mvebu_v7_defconfig FAIL
> > >> > pxa3xx_defconfig FAIL
> > >> > raumfeld_defconfig FAIL
> > >> >
> > >> > mvebu_v7_defconfig (arm) — FAIL, 2 errors, 0 warnings, 0 section mismatches
> > >> >
> > >> > Errors:
> > >> > drivers/mtd/nand/pxa3xx_nand.c:918:2: error: duplicate case value
> > >> > drivers/mtd/nand/pxa3xx_nand.c:915:2: error: previously used here
> > >>
> > >> Hi Greg,
> > >>
> > >> Commit fee4380f368e ("mtd: nand: pxa3xx: Fix READOOB implementation") was
> > >> apparently backported in error, it looks like it should just be
> > >> dropped here in 4.4.y.
> > >>
> > >> The commit lists 'Fixes: 43bcfd2bb24a ("mtd: nand: pxa3xx: Add driver-specific
> > >> ECC BCH support")', that commit was merged into v4.14, so backporting the
> > >> fix further is probably not appropriate for 4.9 or earlier kernels either.
> > >
> > > $ git describe --contains 43bcfd2bb24a
> > > v3.14-rc1~65^2~127
> > >
> > > That is why I backported these patches this far.
> > >
> > > I'll drop the patch now, but the Fixes line is the problem here :)
> >
> > I think my mistake in the report was misreading v3.14 as v4.14. That means we
> > still need the fix, just as Boris explained, it just needs to be done
> > differently
> > for older kernels.
>
> Hm, actually I was wrong with my Fixes tag, it seems the bug has been
> introduced by 'c2cdace755b5 ("mtd: nand: pxa3xx_nand: add support for
> partial chunks")', so the fix is not needed for pre-4.6 kernels.
oops, also dropped it from 4.9, so I put it back there.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-08 16:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5a535545.93b5df0a.a7ca3.53c1@mx.google.com>
2018-01-08 13:16 ` stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b) Arnd Bergmann
2018-01-08 13:35 ` Boris Brezillon
2018-01-08 13:44 ` gregkh
2018-01-08 14:01 ` Arnd Bergmann
2018-01-08 15:30 ` Boris Brezillon
2018-01-08 16:34 ` gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).