From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, "Andrew Lunn" <andrew@lunn.ch>,
"Yehuda Yitschak" <yehuday@marvell.com>,
"Jason Cooper" <jason@lakedaemon.net>,
"Hanna Hawa" <hannah@marvell.com>,
stable@vger.kernel.org, "Nadav Haklai" <nadavh@marvell.com>,
"Victor Gu" <xigu@marvell.com>,
"Miquèl Raynal" <miquel.raynal@free-electrons.com>,
"Gregory Clement" <gregory.clement@free-electrons.com>,
"Antoine Tenart" <antoine.tenart@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2 2/7] PCI: aardvark: set PIO_ADDR_LS correctly in advk_pcie_rd_conf()
Date: Tue, 9 Jan 2018 17:10:22 +0100 [thread overview]
Message-ID: <20180109171022.7c989501@windsurf.lan> (raw)
In-Reply-To: <20171005172545.GQ25517@bhelgaas-glaptop.roam.corp.google.com>
Hello,
On Thu, 5 Oct 2017 12:25:45 -0500, Bjorn Helgaas wrote:
> > diff --git a/drivers/pci/host/pci-aardvark.c b/drivers/pci/host/pci-aardvark.c
> > index da2881ba7737..af7a9c4a61a4 100644
> > --- a/drivers/pci/host/pci-aardvark.c
> > +++ b/drivers/pci/host/pci-aardvark.c
> > @@ -459,7 +459,7 @@ static int advk_pcie_rd_conf(struct pci_bus *bus, u32 devfn,
> > advk_writel(pcie, reg, PIO_CTRL);
> >
> > /* Program the address registers */
> > - reg = PCIE_BDF(devfn) | PCIE_CONF_REG(where);
> > + reg = PCIE_CONF_ADDR(bus->number, devfn, where);
>
> I think PCIE_BDF() is now unused and should be removed.
True, I'll fix this in v3.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2018-01-09 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170928125838.11887-1-thomas.petazzoni@free-electrons.com>
2017-09-28 12:58 ` [PATCH v2 1/7] PCI: aardvark: fix logic in PCI configuration read/write functions Thomas Petazzoni
2017-10-05 17:23 ` Bjorn Helgaas
2018-01-09 16:49 ` Thomas Petazzoni
2018-01-10 1:11 ` Bjorn Helgaas
2017-09-28 12:58 ` [PATCH v2 2/7] PCI: aardvark: set PIO_ADDR_LS correctly in advk_pcie_rd_conf() Thomas Petazzoni
2017-10-05 17:25 ` Bjorn Helgaas
2018-01-09 16:10 ` Thomas Petazzoni [this message]
2017-09-28 12:58 ` [PATCH v2 7/7] PCI: aardvark: define IRQ related hooks in pci_host_bridge Thomas Petazzoni
2017-10-05 17:55 ` Bjorn Helgaas
2017-10-05 19:25 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109171022.7c989501@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@free-electrons.com \
--cc=bhelgaas@google.com \
--cc=gregory.clement@free-electrons.com \
--cc=hannah@marvell.com \
--cc=helgaas@kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=miquel.raynal@free-electrons.com \
--cc=nadavh@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stable@vger.kernel.org \
--cc=xigu@marvell.com \
--cc=yehuday@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).