stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Jean-Philippe Brucker <Jean-Philippe.Brucker@arm.com>
Cc: Robin Murphy <Robin.Murphy@arm.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Will Deacon <Will.Deacon@arm.com>
Subject: Re: FAILED: patch "[PATCH] iommu/arm-smmu-v3: Don't free page table ops twice" failed to apply to 4.4-stable tree
Date: Wed, 10 Jan 2018 17:30:06 +0100	[thread overview]
Message-ID: <20180110163006.GB4951@kroah.com> (raw)
In-Reply-To: <20180108145635.GA5852@e106794-lin.localdomain>

On Mon, Jan 08, 2018 at 02:56:36PM +0000, Jean-Philippe Brucker wrote:
> Hi,
> 
> On Sun, Jan 07, 2018 at 08:35:02AM +0000, gregkh@linuxfoundation.org wrote:
> > The patch below does not apply to the 4.4-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> 
> Please consider applying the updated backport for 4.4-stable, below.
> 
> Thanks,
> Jean
> 
> --- 8< ---
> >From 36a792dfdaff7fafeb7b870cc0f86a339df9ea25 Mon Sep 17 00:00:00 2001
> From: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
> Date: Thu, 14 Dec 2017 11:03:01 +0000
> Subject: [PATCH] iommu/arm-smmu-v3: Don't free page table ops twice
> 
> commit 57d72e159b60456c8bb281736c02ddd3164037aa upstream.
> 
> Kasan reports a double free when finalise_stage_fn fails: the io_pgtable
> ops are freed by arm_smmu_domain_finalise and then again by
> arm_smmu_domain_free. Prevent this by leaving pgtbl_ops empty on failure.
> 
> Fixes: 48ec83bcbcf5 ("iommu/arm-smmu: Add initial driver support for ARM SMMUv3 devices")
> Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
> ---
>  drivers/iommu/arm-smmu-v3.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

This does not apply to the 4.4-stable tree:

checking file drivers/iommu/arm-smmu-v3.c
Hunk #1 FAILED at 1541.
1 out of 1 hunk FAILED

Are you sure you tried it?

thanks,

greg k-h

  reply	other threads:[~2018-01-10 16:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-07  8:35 FAILED: patch "[PATCH] iommu/arm-smmu-v3: Don't free page table ops twice" failed to apply to 4.4-stable tree gregkh
2018-01-08 14:56 ` Jean-Philippe Brucker
2018-01-10 16:30   ` gregkh [this message]
2018-01-10 18:37     ` [PATCH v4.4.y] iommu/arm-smmu-v3: Don't free page table ops twice Jean-Philippe Brucker
2018-01-10 19:13       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180110163006.GB4951@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Jean-Philippe.Brucker@arm.com \
    --cc=Robin.Murphy@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).