From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:41476 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965908AbeAJQcq (ORCPT ); Wed, 10 Jan 2018 11:32:46 -0500 Date: Wed, 10 Jan 2018 17:30:06 +0100 From: "gregkh@linuxfoundation.org" To: Jean-Philippe Brucker Cc: Robin Murphy , "stable@vger.kernel.org" , Will Deacon Subject: Re: FAILED: patch "[PATCH] iommu/arm-smmu-v3: Don't free page table ops twice" failed to apply to 4.4-stable tree Message-ID: <20180110163006.GB4951@kroah.com> References: <151531410217775@kroah.com> <20180108145635.GA5852@e106794-lin.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180108145635.GA5852@e106794-lin.localdomain> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Jan 08, 2018 at 02:56:36PM +0000, Jean-Philippe Brucker wrote: > Hi, > > On Sun, Jan 07, 2018 at 08:35:02AM +0000, gregkh@linuxfoundation.org wrote: > > The patch below does not apply to the 4.4-stable tree. > > If someone wants it applied there, or to any other stable or longterm > > tree, then please email the backport, including the original git commit > > id to . > > Please consider applying the updated backport for 4.4-stable, below. > > Thanks, > Jean > > --- 8< --- > >From 36a792dfdaff7fafeb7b870cc0f86a339df9ea25 Mon Sep 17 00:00:00 2001 > From: Jean-Philippe Brucker > Date: Thu, 14 Dec 2017 11:03:01 +0000 > Subject: [PATCH] iommu/arm-smmu-v3: Don't free page table ops twice > > commit 57d72e159b60456c8bb281736c02ddd3164037aa upstream. > > Kasan reports a double free when finalise_stage_fn fails: the io_pgtable > ops are freed by arm_smmu_domain_finalise and then again by > arm_smmu_domain_free. Prevent this by leaving pgtbl_ops empty on failure. > > Fixes: 48ec83bcbcf5 ("iommu/arm-smmu: Add initial driver support for ARM SMMUv3 devices") > Signed-off-by: Jean-Philippe Brucker > --- > drivers/iommu/arm-smmu-v3.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) This does not apply to the 4.4-stable tree: checking file drivers/iommu/arm-smmu-v3.c Hunk #1 FAILED at 1541. 1 out of 1 hunk FAILED Are you sure you tried it? thanks, greg k-h