From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:44210 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750861AbeAJTNm (ORCPT ); Wed, 10 Jan 2018 14:13:42 -0500 Date: Wed, 10 Jan 2018 20:13:42 +0100 From: Greg KH To: Jean-Philippe Brucker Cc: stable@vger.kernel.org, Will.Deacon@arm.com, Robin.Murphy@arm.com Subject: Re: [PATCH v4.4.y] iommu/arm-smmu-v3: Don't free page table ops twice Message-ID: <20180110191342.GA18619@kroah.com> References: <20180110163006.GB4951@kroah.com> <20180110183711.16655-1-jean-philippe.brucker@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180110183711.16655-1-jean-philippe.brucker@arm.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Jan 10, 2018 at 06:37:11PM +0000, Jean-Philippe Brucker wrote: > commit 57d72e159b60456c8bb281736c02ddd3164037aa upstream. > > Kasan reports a double free when finalise_stage_fn fails: the io_pgtable > ops are freed by arm_smmu_domain_finalise and then again by > arm_smmu_domain_free. Prevent this by leaving pgtbl_ops empty on failure. > > Fixes: 48ec83bcbcf5 ("iommu/arm-smmu: Add initial driver support for ARM SMMUv3 devices") > Signed-off-by: Jean-Philippe Brucker > --- > > The whitespaces got corrupted last time, sorry about that. Let's hope > this one works. It worked, thanks, now queued up. greg k-h