From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mx2.suse.de ([195.135.220.15]:40554 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751892AbeAJUDW (ORCPT <rfc822;stable@vger.kernel.org>);
        Wed, 10 Jan 2018 15:03:22 -0500
Date: Wed, 10 Jan 2018 21:03:18 +0100
From: Jean Delvare <jdelvare@suse.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, Ales Novak <alnovak@suse.cz>,
        Seunghun Han <kkamagui@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>,
        Vikas C Sajjan <vikas.cha.sajjan@hpe.com>,
        Sunil V L <sunil.vl@hpe.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: Regression caused by commit dad5ab0db8de ("x86/acpi: Prevent
 out of bound access caused by broken ACPI tables")
Message-ID: <20180110210318.73430ed0@endymion>
In-Reply-To: <20180110191044.GA15591@kroah.com>
References: <20180110192822.1cf7d84c@endymion>
        <20180110191044.GA15591@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

Hi Greg,

On Wed, 10 Jan 2018 20:10:44 +0100, Greg KH wrote:
> Many thanks for the report, I've queued up 252714155f04 now.  I don't
> think 4ee2ec1b1225 needs to be merged, unless the acpi maintainers think
> it is a good idea to do so.
> 
> Rafael, any thoughts?

FWIW we applied both in SUSE kernels. I did not make the decision but I
approve it. Having duplicated code in our kernel when there's only one
occurrence of the same code upstream looks dangerous. If there ever is
a bug fixed in that function and we backport the fix, you can be sure
that only one of the copies will get fixed and the bug will remain in
the other.

-- 
Jean Delvare
SUSE L3 Support