From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:41890 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932223AbeAKHTT (ORCPT ); Thu, 11 Jan 2018 02:19:19 -0500 Date: Thu, 11 Jan 2018 08:19:05 +0100 From: Greg KH To: Jean Delvare Cc: stable@vger.kernel.org, Ales Novak , Seunghun Han , Thomas Gleixner , Ingo Molnar , Vikas C Sajjan , Sunil V L , "Rafael J. Wysocki" Subject: Re: Regression caused by commit dad5ab0db8de ("x86/acpi: Prevent out of bound access caused by broken ACPI tables") Message-ID: <20180111071905.GA2950@kroah.com> References: <20180110192822.1cf7d84c@endymion> <20180110191044.GA15591@kroah.com> <20180110210318.73430ed0@endymion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180110210318.73430ed0@endymion> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Jan 10, 2018 at 09:03:18PM +0100, Jean Delvare wrote: > Hi Greg, > > On Wed, 10 Jan 2018 20:10:44 +0100, Greg KH wrote: > > Many thanks for the report, I've queued up 252714155f04 now. I don't > > think 4ee2ec1b1225 needs to be merged, unless the acpi maintainers think > > it is a good idea to do so. > > > > Rafael, any thoughts? > > FWIW we applied both in SUSE kernels. I did not make the decision but I > approve it. Having duplicated code in our kernel when there's only one > occurrence of the same code upstream looks dangerous. If there ever is > a bug fixed in that function and we backport the fix, you can be sure > that only one of the copies will get fixed and the bug will remain in > the other. Good idea, I've now queued it up as well, thanks. greg k-h