From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:53678 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752841AbeALHcz (ORCPT ); Fri, 12 Jan 2018 02:32:55 -0500 Date: Fri, 12 Jan 2018 08:32:55 +0100 From: Greg Kroah-Hartman To: Andy Lutomirski Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov , Kees Cook , Peter Zijlstra , Hugh Dickins , stable@vger.kernel.org Subject: Re: [PATCH] selftests/x86: Add test_vsyscall Message-ID: <20180112073255.GF25517@kroah.com> References: <2b9c5a174c1d60fd7774461d518aa75598b1d8fd.1515719552.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2b9c5a174c1d60fd7774461d518aa75598b1d8fd.1515719552.git.luto@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Jan 11, 2018 at 05:16:51PM -0800, Andy Lutomirski wrote: > This tests that the vsyscall entries do what they're expected to do. > It also confirms that attempts to read the vsyscall page behave as > expected. > > If changes are made to the vsyscall code or its memory map handling, > running this test in all three of vsyscall=none, vsyscall=emulate, > and vsyscall=native are helpful. > > (Because it's easy, this also compares the vsyscall results to their > vDSO equivalents.) > > Cc: stable@vger.kernel.org > Signed-off-by: Andy Lutomirski > --- Tested-by: Greg Kroah-Hartman Reviewed-by: Greg Kroah-Hartman > Note to KAISER backporters: please test this under all three > vsyscall modes. Also, in the emulate and native modes, make sure > that test_vsyscall_64 agrees with the command line or config > option as to which mode you're in. It's quite easy to mess up > the kernel such that native mode accidentally emulates > or vice versa. > > Greg, etc: please backport this to all your Meltdown-patched > kernels. It'll help make sure the patches didn't regress > vsyscalls. I will gladly do so, thanks so much for this test. greg k-h