From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:43200 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750784AbeAORqm (ORCPT ); Mon, 15 Jan 2018 12:46:42 -0500 Date: Mon, 15 Jan 2018 18:46:42 +0100 From: Greg KH To: Josh Poimboeuf Cc: David Woodhouse , ak@linux.intel.com, dave.hansen@intel.com, jikos@kernel.org, keescook@google.com, luto@amacapital.net, peterz@infradead.org, pjt@google.com, riel@redhat.com, tglx@linutronix.de, tim.c.chen@linux.intel.com, torvalds@linux-foundation.org, stable@vger.kernel.org, stable-commits@vger.kernel.org Subject: Re: Patch "objtool: Allow alternatives to be ignored" has been added to the 4.9-stable tree Message-ID: <20180115174642.GA24122@kroah.com> References: <15160071885216@kroah.com> <1516017311.22147.147.camel@infradead.org> <20180115170054.6baepkgihtla4nub@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180115170054.6baepkgihtla4nub@treble> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Jan 15, 2018 at 11:00:54AM -0600, Josh Poimboeuf wrote: > On Mon, Jan 15, 2018 at 12:55:11PM +0100, David Woodhouse wrote: > > On Mon, 2018-01-15 at 10:06 +0100, gregkh@linuxfoundation.org wrote: > > > This is a note to let you know that I've just added the patch titled > > > > > > ����objtool: Allow alternatives to be ignored > > > > > > to the 4.9-stable tree which can be found at: > > > ����http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > > > The filename of the patch is: > > > �����objtool-allow-alternatives-to-be-ignored.patch > > > and it can be found in the queue-4.9 subdirectory. > > > > Hm... they aren't being ignored entirely. > > > > arch/x86/crypto/camellia-aesni-avx2-asm_64.o: warning: objtool: .altinstr_replacement+0xf: return instruction outside of a callable function > > > > Josh? > > This should fix it (to be applied on top): > > ---- > > From: Josh Poimboeuf > Subject: [PATCH] objtool: Fix retpoline support for pre-ORC objtool > > Objtool 1.0 (pre-ORC) produces the following warning when it encounters > a retpoline: > > arch/x86/crypto/camellia-aesni-avx2-asm_64.o: warning: objtool: .altinstr_replacement+0xf: return instruction outside of a callable function > > That warning is meant to catch GCC bugs and missing ENTRY/ENDPROC > annotations, neither of which are applicable to alternatives. Silence > the warning for alternative instructions, just like objtool 2.0 already > does. > > Reported-by: David Woodhouse > Signed-off-by: Josh Poimboeuf > --- > tools/objtool/builtin-check.c | 8 ++++++++ > 1 file changed, 8 insertions(+) Wonderful! Thanks so much for this, it works great for me, now queued up. greg k-h