From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:43900 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbeAPFyj (ORCPT ); Tue, 16 Jan 2018 00:54:39 -0500 Date: Tue, 16 Jan 2018 06:54:37 +0100 From: Greg KH To: Holger =?iso-8859-1?Q?Hoffst=E4tte?= Cc: =?iso-8859-1?Q?Fran=E7ois?= Valenduc , stable@vger.kernel.org Subject: Re: Linux 4.14.10 Message-ID: <20180116055437.GD18698@kroah.com> References: <20171229171043.GA8641@kroah.com> <20171229173254.GA12289@kroah.com> <87f3bf20-b504-9b32-460b-60c065b91f64@gmail.com> <20171229174241.GA13617@kroah.com> <21b9c8c7-3c61-5762-85f1-f46affde4c0a@applied-asynchrony.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <21b9c8c7-3c61-5762-85f1-f46affde4c0a@applied-asynchrony.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Jan 15, 2018 at 11:07:33PM +0100, Holger Hoffst�tte wrote: > On 12/29/17 18:42, Greg KH wrote: > > On Fri, Dec 29, 2017 at 06:38:15PM +0100, Fran�ois Valenduc wrote: > >> Le 29/12/17 � 18:32, Greg KH a �crit�: > >>> On Fri, Dec 29, 2017 at 06:18:18PM +0100, Fran�ois Valenduc wrote: > >>>> No solution found to the permissions on tools/objtool/sync-check.sh ? > >>> Is the permission not correct in the repo? Is it not correct in the > >>> patch I sent out in response to this? > >>> > >>>> git or patch is not smart enough for that ? It's obviously extremely > >>>> easy to solve the problem, but I find that rather strange. > >>> git and patch handle it just fine, quilt has issues, which I worked > >>> around very easily. Are you having problems with the git tree as-is? > >>> > >>> thanks, > >>> > >>> greg k-h > >> > >> It seems I messed up with enigmail. So in case you couldn't read my > >> reply, I send it again. > >> > >> I didn't see the posts of Toralf Forster before replying to your > >> annoucement. But my problem is exactly the same. I extracted the patch > >> from git (with git diff v4.14.9..v4.14.10). The permissions are also > >> wrong if I download the patch from kernel.org. In both cases, > >> sync-check.sh is not executable. > > > > That's fine, but when you apply the patch, you need to keep the file > > mode. So be careful as to how you apply it. > > > > I just got told that there's a patch in Andrew's tree that fixes this > > (it doesn't rely on the mode of the file.) Hopefully it gets into > > Linus's tree soon and then I can queue it up into the stable tree to > > help people who don't only use git. > > This is now in 4.15-rc8 as commit 0f908ccbeca aka: > "tools/objtool/Makefile: don't assume sync-check.sh is executable" > > I've been using it since it came out, would be great to add that > to all stable series where 3bd51c5a371de was applied. Thanks, I'll queue it up for the next round after this one. Then the gentoo users will be a bit happier :) greg k-h