From: Greg KH <gregkh@linuxfoundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Joakim.Tjernlund@infinera.com, holger@applied-asynchrony.com,
jpoimboe@redhat.com, mingo@kernel.org, nicolasbock@gentoo.org,
torvalds@linux-foundation.org, stable@vger.kernel.org,
stable-commits@vger.kernel.org
Subject: Re: Patch "tools/objtool/Makefile: don't assume sync-check.sh is executable" has been added to the 4.14-stable tree
Date: Thu, 18 Jan 2018 08:34:20 +0100 [thread overview]
Message-ID: <20180118073420.GA25849@kroah.com> (raw)
In-Reply-To: <20180117150714.1d940b03c5bec4eb82eeace1@linux-foundation.org>
On Wed, Jan 17, 2018 at 03:07:14PM -0800, Andrew Morton wrote:
> On Wed, 17 Jan 2018 11:02:12 +0100 <gregkh@linuxfoundation.org> wrote:
>
> >
> > This is a note to let you know that I've just added the patch titled
> >
> > tools/objtool/Makefile: don't assume sync-check.sh is executable
> >
> > to the 4.14-stable tree which can be found at:
> > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >
> > The filename of the patch is:
> > tools-objtool-makefile-don-t-assume-sync-check.sh-is-executable.patch
> > and it can be found in the queue-4.14 subdirectory.
> >
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
> >
> >
> > >From 0f908ccbeca99ddf0ad60afa710e72aded4a5ea7 Mon Sep 17 00:00:00 2001
> > From: Andrew Morton <akpm@linux-foundation.org>
> > Date: Fri, 12 Jan 2018 16:53:17 -0800
> > Subject: tools/objtool/Makefile: don't assume sync-check.sh is executable
> >
> > From: Andrew Morton <akpm@linux-foundation.org>
> >
> > commit 0f908ccbeca99ddf0ad60afa710e72aded4a5ea7 upstream.
> >
> > patch(1) loses the x bit. So if a user follows our patching
> > instructions in Documentation/admin-guide/README.rst, their kernel will
> > not compile.
> >
> > Fixes: 3bd51c5a371de ("objtool: Move kernel headers/code sync check to a script")
> > Reported-by: Nicolas Bock <nicolasbock@gentoo.org>
> > Reported-by Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: Holger Hoffst�tte <holger@applied-asynchrony.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> I'm curious. 3bd51c5a371de wasn't marked for any -stable so why is its
> fix being merged?
Because that commit is in the 4.14.10 release as part of the whole PTI
mess. Distros like Gentoo that package the kernel as a patch on top of
a clean tree break when trying to build the kernel without this commit.
thanks,
greg k-h
prev parent reply other threads:[~2018-01-18 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 10:02 Patch "tools/objtool/Makefile: don't assume sync-check.sh is executable" has been added to the 4.14-stable tree gregkh
2018-01-17 23:07 ` Andrew Morton
2018-01-17 23:44 ` Holger Hoffstätte
2018-01-17 23:51 ` Holger Hoffstätte
2018-01-18 7:34 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118073420.GA25849@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Joakim.Tjernlund@infinera.com \
--cc=akpm@linux-foundation.org \
--cc=holger@applied-asynchrony.com \
--cc=jpoimboe@redhat.com \
--cc=mingo@kernel.org \
--cc=nicolasbock@gentoo.org \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).