From: Guenter Roeck <linux@roeck-us.net>
To: Greg Kroah-Hartman <gregkh@linux-foundation.org>
Cc: stable@vger.kernel.org
Subject: Re: objtool patches needed in v4.14.y (and possibly older kernels)
Date: Thu, 18 Jan 2018 11:52:13 -0800 [thread overview]
Message-ID: <20180118195212.GB28449@roeck-us.net> (raw)
In-Reply-To: <20180118135950.GB24935@kroah.com>
On Thu, Jan 18, 2018 at 02:59:50PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 17, 2018 at 01:49:07PM -0800, Guenter Roeck wrote:
> > Hi Greg,
> >
> > please add the following patches to v4.14.y.
> >
> > ce90aaf5cde4 objtool: Fix seg fault with clang-compiled objects
> > e7e83dd3ff1d objtool: Fix Clang enum conversion warning
> > 0f908ccbeca9 tools/objtool/Makefile: don't assume sync-check.sh is executable
> > d89e426499cf objtool: Fix seg fault caused by missing parameter
> >
> > They are needed to avoid problems when building v4.14.y with clang.
> > It might be useful to apply the same patches to older kernels
> > if/when retpoline related changes are applied to those kernels.
>
> From what I can tell, these only are needed for 4.14, the 4.9 and 4.4
> backports of repoline didn't backport the huge objtool changes to ORC.
> So hopefully it's all good there, otherwise I'm sure someone from the
> Android team will complain I broke building with CLANG :)
>
Unfortunately, the problem is much worse: The Google toolchain with retpoline
support causes a crash with the latest version of objtool. No idea if that is
an objtool problem or a compiler problem; it was introduced with 'objtool:
Allow alternatives to be ignored'.
You might also want to add
2a0098d70640 objtool: Fix seg fault with gold linker
but that has a Fixes: tag and might be in your queue already.
Thanks,
Guenter
next prev parent reply other threads:[~2018-01-18 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 21:49 objtool patches needed in v4.14.y (and possibly older kernels) Guenter Roeck
2018-01-18 13:59 ` Greg Kroah-Hartman
2018-01-18 19:52 ` Guenter Roeck [this message]
2018-01-19 7:49 ` Greg Kroah-Hartman
2018-01-19 9:15 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118195212.GB28449@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gregkh@linux-foundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).