From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:44732 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754719AbeASNOD (ORCPT ); Fri, 19 Jan 2018 08:14:03 -0500 Date: Fri, 19 Jan 2018 14:13:55 +0100 From: Greg Kroah-Hartman To: Daniel Bristot de Oliveira Cc: Ben Hutchings , linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Peter Zijlstra (Intel)" , Juri Lelli , Linus Torvalds , Luca Abeni , Mike Galbraith , Romulo Silva de Oliveira , Steven Rostedt , Thomas Gleixner , Tommaso Cucinotta , Ingo Molnar , Sasha Levin Subject: Re: [PATCH 4.4 045/115] sched/deadline: Throttle a constrained deadline task activated after the deadline Message-ID: <20180119131355.GA1866@kroah.com> References: <20171218152851.886086917@linuxfoundation.org> <20171218152855.351654393@linuxfoundation.org> <1516323645.3417.5.camel@codethink.co.uk> <20180119075304.GE25687@kroah.com> <20180119124003.GA18519@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180119124003.GA18519@kroah.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Jan 19, 2018 at 01:40:03PM +0100, Greg Kroah-Hartman wrote: > On Fri, Jan 19, 2018 at 01:16:01PM +0100, Daniel Bristot de Oliveira wrote: > > On 01/19/2018 08:53 AM, Greg Kroah-Hartman wrote: > > > On Fri, Jan 19, 2018 at 01:00:45AM +0000, Ben Hutchings wrote: > > >> On Mon, 2017-12-18 at 16:48 +0100, Greg Kroah-Hartman wrote: > > >>> 4.4-stable review patch.��If anyone has any objections, please let me > > >>> know. > > >>> > > >>> ------------------ > > >>> > > >>> From: Daniel Bristot de Oliveira > > >>> > > >>> > > >>> [ Upstream commit df8eac8cafce7d086be3bd5cf5a838fa37594dfb ] > > >> [...] > > >> > > >> I think this needs another fix on top: > > >> > > >> commit ae83b56a56f8d9643dedbee86b457fa1c5d42f59 > > >> Author: Xunlei Pang > > >> Date:���Wed May 10 21:03:37 2017 +0800 > > >> > > >> ����sched/deadline: Zero out positive runtime after throttling constrained tasks > > > > > > Now queued up, thanks. > > > > > >> There's another fix related to this, but it doesn't appear to�fix a > > >> regression and I don't know how critical it is: > > >> > > >> commit 3effcb4247e74a51f5d8b775a1ee4abf87cc089a > > >> Author: Daniel Bristot de Oliveira > > >> Date:���Mon May 29 16:24:03 2017 +0200 > > >> > > >> ����sched/deadline: Use the revised wakeup rule for suspending constrained dl tasks > > > > > > I'll hold off on this one until someone actually asks for it, as it's a > > > big change. > > > > > > thanks again for the review, > > > > Hi, > > > > This fix is also needed. Do you guys need some help in the backport? if > > so, please let me know! I will be glad to help. > > I've now backported it, was just some comment and formatting issues that > needed to be adjusted. Nope, my attempt broke the build :( If you could provide a working backport, that would be great. thanks, greg k-h