Re: [PATCH] x86: Use __nostackprotect for sme_encrypt_kernel

Re: [PATCH] x86: Use __nostackprotect for sme_encrypt_kernel

[Gabriel C]

On 21.01.2018 02:23, Linus Torvalds wrote:
> On Sat, Jan 20, 2018 at 5:14 PM, Laura Abbott <labbott@redhat.com> wrote:
>>
>> I hadn't seen this picked up yet so sending explicitly
> 
> Ingo, I just took this directly as a patch.

Added stable to CC since the patch series this patch fixes
is in stable-queue.

Regards,

Gabriel C

Re: [PATCH] x86: Use __nostackprotect for sme_encrypt_kernel

[Linus Torvalds]

On Sat, Jan 20, 2018 at 5:49 PM, Gabriel C <nix.or.die@gmail.com> wrote:
>
> Added stable to CC since the patch series this patch fixes
> is in stable-queue.

Oh, it wasn't clear from the commit message. But I guess the "Fixes:"
tag would have caught Greg's eye regardless.

Anyway, Laura's fix is commit 91cfc88c66bf ("x86: Use __nostackprotect
for sme_encrypt_kernel") in my tree.

                Linus

Re: [PATCH] x86: Use __nostackprotect for sme_encrypt_kernel

[Greg Kroah-Hartman]

On Sat, Jan 20, 2018 at 08:16:31PM -0800, Linus Torvalds wrote:
> On Sat, Jan 20, 2018 at 5:49 PM, Gabriel C <nix.or.die@gmail.com> wrote:
> >
> > Added stable to CC since the patch series this patch fixes
> > is in stable-queue.
> 
> Oh, it wasn't clear from the commit message. But I guess the "Fixes:"
> tag would have caught Greg's eye regardless.

Ugh, I am _so_ behind in looking at patches that only have a Fixes: tag
in it and not a "Cc: stable@" tag, due to the recent high-volume of the
latter.

But they will end up in a mbox that I need to dig out of eventually, but
it will take time, so if you know you want a patch in a stable release,
it's much easier to just use the "Cc: stable@" tag please.

thanks,

greg k-h

Re: [PATCH] x86: Use __nostackprotect for sme_encrypt_kernel

[Ingo Molnar]

* Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Sat, Jan 20, 2018 at 08:16:31PM -0800, Linus Torvalds wrote:
> > On Sat, Jan 20, 2018 at 5:49 PM, Gabriel C <nix.or.die@gmail.com> wrote:
> > >
> > > Added stable to CC since the patch series this patch fixes
> > > is in stable-queue.
> > 
> > Oh, it wasn't clear from the commit message. But I guess the "Fixes:"
> > tag would have caught Greg's eye regardless.
> 
> Ugh, I am _so_ behind in looking at patches that only have a Fixes: tag
> in it and not a "Cc: stable@" tag, due to the recent high-volume of the
> latter.
> 
> But they will end up in a mbox that I need to dig out of eventually, but
> it will take time, so if you know you want a patch in a stable release,
> it's much easier to just use the "Cc: stable@" tag please.

Just to make it easier, please put this upstream fix into -stable:

  91cfc88c66bf: ("x86: Use __nostackprotect for sme_encrypt_kernel")

I believe all the prerequisite upstream commits are in -stable already:

 1303880179e6: x86/mm: Clean up register saving in the __enc_copy() assembly code
 bacf6b499e11: x86/mm: Use a struct to reduce parameters for SME PGD mapping
 2b5d00b6c2cd: x86/mm: Centralize PMD flags in sme_encrypt_kernel()
 cc5f01e28d6c: x86/mm: Prepare sme_encrypt_kernel() for PAGE aligned encryption
 107cd2532181: x86/mm: Encrypt the initrd earlier for BSP microcode update

Thanks,

	Ingo

Re: [PATCH] x86: Use __nostackprotect for sme_encrypt_kernel

[Greg Kroah-Hartman]

On Sun, Jan 21, 2018 at 10:50:20AM +0100, Ingo Molnar wrote:
> 
> * Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> > On Sat, Jan 20, 2018 at 08:16:31PM -0800, Linus Torvalds wrote:
> > > On Sat, Jan 20, 2018 at 5:49 PM, Gabriel C <nix.or.die@gmail.com> wrote:
> > > >
> > > > Added stable to CC since the patch series this patch fixes
> > > > is in stable-queue.
> > > 
> > > Oh, it wasn't clear from the commit message. But I guess the "Fixes:"
> > > tag would have caught Greg's eye regardless.
> > 
> > Ugh, I am _so_ behind in looking at patches that only have a Fixes: tag
> > in it and not a "Cc: stable@" tag, due to the recent high-volume of the
> > latter.
> > 
> > But they will end up in a mbox that I need to dig out of eventually, but
> > it will take time, so if you know you want a patch in a stable release,
> > it's much easier to just use the "Cc: stable@" tag please.
> 
> Just to make it easier, please put this upstream fix into -stable:
> 
>   91cfc88c66bf: ("x86: Use __nostackprotect for sme_encrypt_kernel")

Thanks, now queued up.

> I believe all the prerequisite upstream commits are in -stable already:
> 
>  1303880179e6: x86/mm: Clean up register saving in the __enc_copy() assembly code
>  bacf6b499e11: x86/mm: Use a struct to reduce parameters for SME PGD mapping
>  2b5d00b6c2cd: x86/mm: Centralize PMD flags in sme_encrypt_kernel()
>  cc5f01e28d6c: x86/mm: Prepare sme_encrypt_kernel() for PAGE aligned encryption
>  107cd2532181: x86/mm: Encrypt the initrd earlier for BSP microcode update

Yes, those are all there already.

greg k-h