From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 21 Jan 2018 17:27:11 +0100 From: Greg KH To: Shuah Khan Cc: valentina.manea.m@gmail.com, shuah@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 4.9] usbip: fix warning in vhci_hcd_probe/lockdep_init_map Message-ID: <20180121162711.GA18144@kroah.com> References: <20180117220343.21725-1-shuahkh@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180117220343.21725-1-shuahkh@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Wed, Jan 17, 2018 at 03:03:43PM -0700, Shuah Khan wrote: > commit 918b8ac55b6c809b70aa05c279087109584e393e upstream > > vhci_hcd calls sysfs_create_group() with dynamically allocated sysfs > attributes triggering the lock-class key not persistent warning. Call > sysfs_attr_init() for dynamically allocated sysfs attributes to fix it. > > vhci_hcd vhci_hcd: USB/IP Virtual Host Controller > vhci_hcd vhci_hcd: new USB bus registered, assigned bus number 2 > BUG: key ffff88006a7e8d18 not in .data! > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:3131 > lockdep_init_map+0x60c/0x770 > DEBUG_LOCKS_WARN_ON(1)[ 1.567044] Modules linked in: > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.9.0-rc7+ #58 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 > ffff88006bce6eb8 ffffffff81f96c8a ffffffff00000a02 1ffff1000d79cd6a > ffffed000d79cd62 000000046bce6ed8 0000000041b58ab3 ffffffff8598af40 > ffffffff81f969f8 0000000000000000 0000000041b58ab3 0000000000000200 > Call Trace: > [< inline >] __dump_stack lib/dump_stack.c:15 > [] dump_stack+0x292/0x398 lib/dump_stack.c:51 > [] __warn+0x19f/0x1e0 kernel/panic.c:550 > [] warn_slowpath_fmt+0xc5/0x110 kernel/panic.c:565 > [] lockdep_init_map+0x60c/0x770 kernel/locking/lockdep.c:3131 > [] __kernfs_create_file+0x114/0x2a0 fs/kernfs/file.c:954 > [] sysfs_add_file_mode_ns+0x225/0x520 fs/sysfs/file.c:305 > [< inline >] create_files fs/sysfs/group.c:64 > [] internal_create_group+0x239/0x8f0 fs/sysfs/group.c:134 > [] sysfs_create_group+0x1f/0x30 fs/sysfs/group.c:156 > [] vhci_start+0x5b4/0x7a0 drivers/usb/usbip/vhci_hcd.c:978 > [] usb_add_hcd+0x8da/0x1c60 drivers/usb/core/hcd.c:2867 > [] vhci_hcd_probe+0x97/0x130 > drivers/usb/usbip/vhci_hcd.c:1103 > --- > --- > ---[ end trace c33c7b202cf3aac8 ]--- > > Reported-by: Andrey Konovalov > Signed-off-by: Shuah Khan > --- > > Greg, > > Please apply this fix to 4.9 stable. I re-discovered the problem > on 4.9.77-rc1 and re-tested the patch on it. Now queued up, thanks. greg k-h