* Re: [PATCH RFC 3/3] MIPS: AR7: ensure the port type's FCR value is used [not found] ` <20171029152721.6770-4-jonas.gorski@gmail.com> @ 2018-01-22 13:07 ` James Hogan 2018-01-22 13:34 ` Greg Kroah-Hartman 0 siblings, 1 reply; 2+ messages in thread From: James Hogan @ 2018-01-22 13:07 UTC (permalink / raw) To: stable Cc: Jonas Gorski, linux-mips, linux-serial, Ralf Baechle, Greg Kroah-Hartman, Yoshihiro YUNOMAE, Florian Fainelli, Nicolas Schichan [-- Attachment #1: Type: text/plain, Size: 1566 bytes --] Hi stable maintainers, On Sun, Oct 29, 2017 at 04:27:21PM +0100, Jonas Gorski wrote: > Since commit aef9a7bd9b67 ("serial/uart/8250: Add tunable RX interrupt > trigger I/F of FIFO buffers"), the port's default FCR value isn't used > in serial8250_do_set_termios anymore, but copied over once in > serial8250_config_port and then modified as needed. > > Unfortunately, serial8250_config_port will never be called if the port > is shared between kernel and userspace, and the port's flag doesn't have > UPF_BOOT_AUTOCONF, which would trigger a serial8250_config_port as well. > > This causes garbled output from userspace: > > [ 5.220000] random: procd urandom read with 49 bits of entropy available > ers > [kee > > Fix this by forcing it to be configured on boot, resulting in the > expected output: > > [ 5.250000] random: procd urandom read with 50 bits of entropy available > Press the [f] key and hit [enter] to enter failsafe mode > Press the [1], [2], [3] or [4] key and hit [enter] to select the debug level > > Fixes: aef9a7bd9b67 ("serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers") > Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> Please can this patch be applied to stable branches 3.17+. It is now merged into mainline as commit 0a5191efe06b ("MIPS: AR7: ensure the port type's FCR value is used"). Commit b084116f8587 ("MIPS: AR7: Ensure that serial ports are properly set up") is a prerequisite for it to apply cleanly, but is already tagged for stable. Thanks James [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH RFC 3/3] MIPS: AR7: ensure the port type's FCR value is used 2018-01-22 13:07 ` [PATCH RFC 3/3] MIPS: AR7: ensure the port type's FCR value is used James Hogan @ 2018-01-22 13:34 ` Greg Kroah-Hartman 0 siblings, 0 replies; 2+ messages in thread From: Greg Kroah-Hartman @ 2018-01-22 13:34 UTC (permalink / raw) To: James Hogan Cc: stable, Jonas Gorski, linux-mips, linux-serial, Ralf Baechle, Yoshihiro YUNOMAE, Florian Fainelli, Nicolas Schichan On Mon, Jan 22, 2018 at 01:07:19PM +0000, James Hogan wrote: > Hi stable maintainers, > > On Sun, Oct 29, 2017 at 04:27:21PM +0100, Jonas Gorski wrote: > > Since commit aef9a7bd9b67 ("serial/uart/8250: Add tunable RX interrupt > > trigger I/F of FIFO buffers"), the port's default FCR value isn't used > > in serial8250_do_set_termios anymore, but copied over once in > > serial8250_config_port and then modified as needed. > > > > Unfortunately, serial8250_config_port will never be called if the port > > is shared between kernel and userspace, and the port's flag doesn't have > > UPF_BOOT_AUTOCONF, which would trigger a serial8250_config_port as well. > > > > This causes garbled output from userspace: > > > > [ 5.220000] random: procd urandom read with 49 bits of entropy available > > ers > > [kee > > > > Fix this by forcing it to be configured on boot, resulting in the > > expected output: > > > > [ 5.250000] random: procd urandom read with 50 bits of entropy available > > Press the [f] key and hit [enter] to enter failsafe mode > > Press the [1], [2], [3] or [4] key and hit [enter] to select the debug level > > > > Fixes: aef9a7bd9b67 ("serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers") > > Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> > > Please can this patch be applied to stable branches 3.17+. It is now > merged into mainline as commit 0a5191efe06b ("MIPS: AR7: ensure the port > type's FCR value is used"). > > Commit b084116f8587 ("MIPS: AR7: Ensure that serial ports are properly > set up") is a prerequisite for it to apply cleanly, but is already > tagged for stable. Now snuck into this round of stable -rc review :) thanks, greg k-h ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-22 13:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20171029152721.6770-1-jonas.gorski@gmail.com>
[not found] ` <20171029152721.6770-4-jonas.gorski@gmail.com>
2018-01-22 13:07 ` [PATCH RFC 3/3] MIPS: AR7: ensure the port type's FCR value is used James Hogan
2018-01-22 13:34 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).