Re: [PATCH 4.4] x86/microcode/intel: Fix BDW late-loading revision check

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Wed, Jan 24, 2018 at 02:31:19AM +0000, Ben Hutchings wrote:
> The backport of commit b94b73733171 ("x86/microcode/intel: Extend BDW
> late-loading with a revision check") to 4.4-stable deleted a "return true"
> statement.  This bug is not present upstream or other stable branches.
> 
> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> ---
>  arch/x86/kernel/cpu/microcode/intel.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
> index b428a8174be1..ee011bd7934d 100644
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -1005,6 +1005,7 @@ static bool is_blacklisted(unsigned int cpu)
>  	    c->microcode < 0x0b000021) {
>  		pr_err_once("Erratum BDF90: late loading with revision < 0x0b000021 (0x%x) disabled.\n", c->microcode);
>  		pr_err_once("Please consider either early loading through initrd/built-in or a potential BIOS update.\n");
> +		return true;
>  	}

That is really odd.  Thanks for catching this, now queued up.

greg k-h