From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:54482 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524AbeAXJU4 (ORCPT ); Wed, 24 Jan 2018 04:20:56 -0500 Date: Wed, 24 Jan 2018 10:20:28 +0100 From: Greg Kroah-Hartman To: Ben Hutchings Cc: stable@vger.kernel.org Subject: Re: [PATCH 4.4] x86/microcode/intel: Fix BDW late-loading revision check Message-ID: <20180124092028.GA19411@kroah.com> References: <20180124023119.kaendz4jiuejowxr@xylophone.i.decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180124023119.kaendz4jiuejowxr@xylophone.i.decadent.org.uk> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Jan 24, 2018 at 02:31:19AM +0000, Ben Hutchings wrote: > The backport of commit b94b73733171 ("x86/microcode/intel: Extend BDW > late-loading with a revision check") to 4.4-stable deleted a "return true" > statement. This bug is not present upstream or other stable branches. > > Signed-off-by: Ben Hutchings > --- > arch/x86/kernel/cpu/microcode/intel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c > index b428a8174be1..ee011bd7934d 100644 > --- a/arch/x86/kernel/cpu/microcode/intel.c > +++ b/arch/x86/kernel/cpu/microcode/intel.c > @@ -1005,6 +1005,7 @@ static bool is_blacklisted(unsigned int cpu) > c->microcode < 0x0b000021) { > pr_err_once("Erratum BDF90: late loading with revision < 0x0b000021 (0x%x) disabled.\n", c->microcode); > pr_err_once("Please consider either early loading through initrd/built-in or a potential BIOS update.\n"); > + return true; > } That is really odd. Thanks for catching this, now queued up. greg k-h