Re: [PATCH 2/8] MIPS: c-r4k: Add r4k_blast_scache_node for Loongson-3

[James Hogan <jhogan@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 983 bytes --]

On Thu, Aug 10, 2017 at 10:04:36AM +0800, Huacai Chen wrote:
> For multi-node Loongson-3 (NUMA configuration), r4k_blast_scache() can
> only flush Node-0's scache. So we add r4k_blast_scache_node() by using
> (CAC_BASE | (node_id << NODE_ADDRSPACE_SHIFT)) instead of CKSEG0 as the
> start address.
> 
> Cc: stable@vger.kernel.org

I believe Loongson 3 support was added in 3.15, so the following is
probably slightly better:

Cc: <stable@vger.kernel.org> # 3.15+

> diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c
> index 81d6a15..7b242e8 100644
> --- a/arch/mips/mm/c-r4k.c
> +++ b/arch/mips/mm/c-r4k.c
> @@ -459,11 +459,28 @@ static void r4k_blast_scache_setup(void)
>  		r4k_blast_scache = blast_scache128;
>  }
>  
> +static void (* r4k_blast_scache_node)(long node);

Checkpatch objects to the space after '*'.

Other than those minor things this patch looks reasonable I think

Reviewed-by: James Hogan <jhogan@kernel.org>

Cheers
James

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]