Patch "net: igmp: fix source address check for IGMPv3 reports" has been added to the 4.14-stable tree

Patch "net: igmp: fix source address check for IGMPv3 reports" has been added to the 4.14-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    net: igmp: fix source address check for IGMPv3 reports

to the 4.14-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     net-igmp-fix-source-address-check-for-igmpv3-reports.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From foo@baz Sun Jan 28 17:35:08 CET 2018
From: Felix Fietkau <nbd@nbd.name>
Date: Fri, 19 Jan 2018 11:50:46 +0100
Subject: net: igmp: fix source address check for IGMPv3 reports

From: Felix Fietkau <nbd@nbd.name>


[ Upstream commit ad23b750933ea7bf962678972a286c78a8fa36aa ]

Commit "net: igmp: Use correct source address on IGMPv3 reports"
introduced a check to validate the source address of locally generated
IGMPv3 packets.
Instead of checking the local interface address directly, it uses
inet_ifa_match(fl4->saddr, ifa), which checks if the address is on the
local subnet (or equal to the point-to-point address if used).

This breaks for point-to-point interfaces, so check against
ifa->ifa_local directly.

Cc: Kevin Cernekee <cernekee@chromium.org>
Fixes: a46182b00290 ("net: igmp: Use correct source address on IGMPv3 reports")
Reported-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 net/ipv4/igmp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.c
@@ -332,7 +332,7 @@ static __be32 igmpv3_get_srcaddr(struct
 		return htonl(INADDR_ANY);
 
 	for_ifa(in_dev) {
-		if (inet_ifa_match(fl4->saddr, ifa))
+		if (fl4->saddr == ifa->ifa_local)
 			return fl4->saddr;
 	} endfor_ifa(in_dev);
 


Patches currently in stable-queue which might be from nbd@nbd.name are

queue-4.14/net-igmp-fix-source-address-check-for-igmpv3-reports.patch

Re: Patch "net: igmp: fix source address check for IGMPv3 reports" has been added to the 4.14-stable tree

[Sebastian Gottschall]

please apply that patch to 4.4 and 3.18 as well. they are affected by 
this regression

thanks,
Sebastian

Am 28.01.2018 um 17:39 schrieb gregkh@linuxfoundation.org:
> This is a note to let you know that I've just added the patch titled
>
>      net: igmp: fix source address check for IGMPv3 reports
>
> to the 4.14-stable tree which can be found at:
>      http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
>       net-igmp-fix-source-address-check-for-igmpv3-reports.patch
> and it can be found in the queue-4.14 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
>
>
>  From foo@baz Sun Jan 28 17:35:08 CET 2018
> From: Felix Fietkau <nbd@nbd.name>
> Date: Fri, 19 Jan 2018 11:50:46 +0100
> Subject: net: igmp: fix source address check for IGMPv3 reports
>
> From: Felix Fietkau <nbd@nbd.name>
>
>
> [ Upstream commit ad23b750933ea7bf962678972a286c78a8fa36aa ]
>
> Commit "net: igmp: Use correct source address on IGMPv3 reports"
> introduced a check to validate the source address of locally generated
> IGMPv3 packets.
> Instead of checking the local interface address directly, it uses
> inet_ifa_match(fl4->saddr, ifa), which checks if the address is on the
> local subnet (or equal to the point-to-point address if used).
>
> This breaks for point-to-point interfaces, so check against
> ifa->ifa_local directly.
>
> Cc: Kevin Cernekee <cernekee@chromium.org>
> Fixes: a46182b00290 ("net: igmp: Use correct source address on IGMPv3 reports")
> Reported-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>   net/ipv4/igmp.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/net/ipv4/igmp.c
> +++ b/net/ipv4/igmp.c
> @@ -332,7 +332,7 @@ static __be32 igmpv3_get_srcaddr(struct
>   		return htonl(INADDR_ANY);
>   
>   	for_ifa(in_dev) {
> -		if (inet_ifa_match(fl4->saddr, ifa))
> +		if (fl4->saddr == ifa->ifa_local)
>   			return fl4->saddr;
>   	} endfor_ifa(in_dev);
>   
>
>
> Patches currently in stable-queue which might be from nbd@nbd.name are
>
> queue-4.14/net-igmp-fix-source-address-check-for-igmpv3-reports.patch
>

-- 
Mit freundlichen Gr�ssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz:  Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Gesch�ftsf�hrer: Peter Steinh�user, Christian Scheele
http://www.dd-wrt.com
email: s.gottschall@dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565

Re: Patch "net: igmp: fix source address check for IGMPv3 reports" has been added to the 4.14-stable tree

[Greg KH]

On Sun, Jan 28, 2018 at 10:46:17PM +0100, Sebastian Gottschall wrote:
> please apply that patch to 4.4 and 3.18 as well. they are affected by this
> regression

Thanks for letting me know, now queued up.

greg k-h