From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dennis Dalessandro <dennis.dalessandro@intel.com>
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org,
"Michael J. Ruhl" <michael.j.ruhl@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH for-next] IB/core: Avoid a potential OOPs for an unused optional parameter
Date: Thu, 1 Feb 2018 15:52:35 -0700 [thread overview]
Message-ID: <20180201225235.GI8590@ziepe.ca> (raw)
In-Reply-To: <20180201203103.11832.81537.stgit@scvm10.sc.intel.com>
On Thu, Feb 01, 2018 at 12:31:06PM -0800, Dennis Dalessandro wrote:
> From: Michael J. Ruhl <michael.j.ruhl@intel.com>
>
> The ev_file is an optional parameter for CQ creation. If the parameter
> is not passed, the ev_file pointer will be NULL. Using that pointer
> to set the cq_context will result in an OOPs.
>
> Verify that ev_file is not NULL before using.
>
> Cc: <stable@vger.kernel.org> # 4.14.x
> Fixes: 9ee79fce3642 ("IB/core: Add completion queue (cq) object actions")
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
> drivers/infiniband/core/uverbs_std_types.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Yep! I was testing this recently and didn't hit this bug, it only
becomes a crash if something tries to use the cq..
Jason
prev parent reply other threads:[~2018-02-01 22:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 20:31 [PATCH for-next] IB/core: Avoid a potential OOPs for an unused optional parameter Dennis Dalessandro
2018-02-01 22:52 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201225235.GI8590@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=ira.weiny@intel.com \
--cc=linux-rdma@vger.kernel.org \
--cc=michael.j.ruhl@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).