stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Shaikh, Azhar" <azhar.shaikh@intel.com>
Cc: "jarkko.sakkinen@linux.intel.com"
	<jarkko.sakkinen@linux.intel.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: patch "[PATCH] tpm_tis: Move ilb_base_addr to tpm_tis_data" was seriously submitted to be applied to the 4.15-stable tree?
Date: Sat, 3 Feb 2018 06:15:26 +0100	[thread overview]
Message-ID: <20180203051526.GA1329@kroah.com> (raw)
In-Reply-To: <5FFFAD06ADE1CA4381B3F0F7C6AF5828A0FAAC@ORSMSX109.amr.corp.intel.com>

On Fri, Feb 02, 2018 at 06:24:16PM +0000, Shaikh, Azhar wrote:
> Hi Greg,
> 
> 
> [1] is merged on the 4.15 stable tree. But this caused 2 issues:
> i. PS/2 keyboard and mouse were broken on an Intel Braswell system. The fix for this is [4].
> ii. There were some corner cases where TPM suspend was failing on Braswell systems. The fix  for this is [2] and [3].
> 
> The patch pointed out by you is [2].
> [3] is dependent on [2]. So to fix the issue on stable tree we will need [2], [3] and [4]. 
> 
> [4] is not there yet on Linus's branch. I think it is queued for 4.16.
> 
> [5] fixes compile time warning introduced in [3].

This email was crazy difficult to read and understand :(

Please, footnotes in emails are for things you can go back and look at
later, after reading the body of a message, not to try to understand
exactly what in the world is going on and what I am supposed to do with
something.

In the future, just put the git sha1 in the email text, no need to link
to anything, we all have zillions of copies of the kernel source on our
own machines.  And sometimes we do not have reliable web access (emails
works great as store and forward.)

Just use the format:
	c382babccba2 ("tpm_tis: Move ilb_base_addr to tpm_tis_data")
to describe a commit id, which can be easily obtained by doing:
	git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"'
(hint, I have an alias for it so I don't have to ever type that again).

So, with all of that, I still have no idea what I am supposed to do
here.  The patch that triggered this email is obviously not a stable
tree patch, as all it does is move code around, right?  Is there
something else I should be doing here?  What action do you want me to
take?

totally confused,

greg k-h

  reply	other threads:[~2018-02-03  8:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-01 12:18 WTF: patch "[PATCH] tpm_tis: Move ilb_base_addr to tpm_tis_data" was seriously submitted to be applied to the 4.15-stable tree? gregkh
2018-02-02 18:24 ` Shaikh, Azhar
2018-02-03  5:15   ` gregkh [this message]
2018-02-04  2:32     ` Shaikh, Azhar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180203051526.GA1329@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=azhar.shaikh@intel.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).