stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org, Michael Lyle <mlyle@lyle.org>,
	Vojtech Pavlik <vojtech@suse.com>, Jens Axboe <axboe@kernel.dk>,
	Sasha Levin <alexander.levin@microsoft.com>
Subject: [PATCH 3.18 12/36] bcache: check return value of register_shrinker
Date: Mon,  5 Feb 2018 10:23:40 -0800	[thread overview]
Message-ID: <20180205182352.277832238@linuxfoundation.org> (raw)
In-Reply-To: <20180205182351.774761393@linuxfoundation.org>

3.18-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Michael Lyle <mlyle@lyle.org>


[ Upstream commit 6c4ca1e36cdc1a0a7a84797804b87920ccbebf51 ]

register_shrinker is now __must_check, so check it to kill a warning.
Caller of bch_btree_cache_alloc in super.c appropriately checks return
value so this is fully plumbed through.

This V2 fixes checkpatch warnings and improves the commit description,
as I was too hasty getting the previous version out.

Signed-off-by: Michael Lyle <mlyle@lyle.org>
Reviewed-by: Vojtech Pavlik <vojtech@suse.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/md/bcache/btree.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- a/drivers/md/bcache/btree.c
+++ b/drivers/md/bcache/btree.c
@@ -808,7 +808,10 @@ int bch_btree_cache_alloc(struct cache_s
 	c->shrink.scan_objects = bch_mca_scan;
 	c->shrink.seeks = 4;
 	c->shrink.batch = c->btree_pages * 2;
-	register_shrinker(&c->shrink);
+
+	if (register_shrinker(&c->shrink))
+		pr_warn("bcache: %s: could not register shrinker",
+				__func__);
 
 	return 0;
 }

  parent reply	other threads:[~2018-02-05 18:23 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 18:23 [PATCH 3.18 00/36] 3.18.94-stable review Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 01/36] Input: do not emit unneeded EV_SYN when suspending Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 02/36] um: link vmlinux with -no-pie Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 03/36] um: Stop abusing __KERNEL__ Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 04/36] um: Remove copy&paste code from init.h Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 06/36] ALSA: seq: Make ioctls race-free Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 07/36] gpio: iop: add missing MODULE_DESCRIPTION/AUTHOR/LICENSE Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 08/36] igb: Free IRQs when device is hotplugged Greg Kroah-Hartman
2018-02-05 18:23 ` Greg Kroah-Hartman [this message]
2018-02-05 18:23 ` [PATCH 3.18 13/36] mac80211: fix the update of path metric for RANN frame Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 15/36] xen-netfront: remove warning when unloading module Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 16/36] nfsd: CLOSE SHOULD return the invalid special stateid for NFSv4.x (x>0) Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 17/36] nfsd: check for use of the closed special stateid Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 18/36] hwmon: (pmbus) Use 64bit math for DIRECT format values Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 19/36] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 20/36] quota: Check for register_shrinker() failure Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 21/36] scsi: ufs: ufshcd: fix potential NULL pointer dereference in ufshcd_config_vreg Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 22/36] media: usbtv: add a new usbid Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 23/36] usb: gadget: dont dereference g until after it has been null checked Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 24/36] staging: rtl8188eu: Fix incorrect response to SIOCGIWESSID Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 26/36] USB: cdc-acm: Do not log urb submission errors on disconnect Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 27/36] CDC-ACM: apply quirk for card reader Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 28/36] USB: serial: io_edgeport: fix possible sleep-in-atomic Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 29/36] usbip: prevent bind loops on devices attached to vhci_hcd Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 30/36] usbip: list: dont list " Greg Kroah-Hartman
2018-02-05 18:23 ` [PATCH 3.18 31/36] USB: serial: simple: add Motorola Tetra driver Greg Kroah-Hartman
2018-02-05 18:24 ` [PATCH 3.18 32/36] usb: f_fs: Prevent gadget unbind if it is already unbound Greg Kroah-Hartman
2018-02-05 18:24 ` [PATCH 3.18 33/36] usb: uas: unconditionally bring back host after reset Greg Kroah-Hartman
2018-02-05 18:24 ` [PATCH 3.18 34/36] selinux: general protection fault in sock_has_perm Greg Kroah-Hartman
2018-02-05 18:24 ` [PATCH 3.18 35/36] spi: imx: do not access registers while clocks disabled Greg Kroah-Hartman
2018-02-05 18:24 ` [PATCH 3.18 36/36] ASoC: pcm512x: add missing MODULE_DESCRIPTION/AUTHOR/LICENSE Greg Kroah-Hartman
2018-02-05 21:35 ` [PATCH 3.18 00/36] 3.18.94-stable review Guenter Roeck
2018-02-06 10:27   ` Greg Kroah-Hartman
2018-02-05 22:15 ` Shuah Khan
     [not found] ` <CALpmF+GKNPabSb1QjBf4nogZRryhU7oD6MRsB8yrU3esT0KxMA@mail.gmail.com>
2018-02-06 10:34   ` Greg Kroah-Hartman
     [not found]     ` <CALpmF+G1Cn7-1Oe2xiNXcGq-cvSPj8GPQTEf0AEF7wN-FDLvFQ@mail.gmail.com>
2018-02-06 13:14       ` Greg Kroah-Hartman
2018-02-06 14:48         ` Guenter Roeck
2018-02-07 14:37           ` Greg Kroah-Hartman
2018-02-07 16:55             ` Guenter Roeck
2018-02-06 14:29 ` Guenter Roeck
2018-02-06 17:00   ` Greg Kroah-Hartman
     [not found] ` <CALpmF+F0K4eXMe2BrHraRyhNK3hktKoEQNNjhdELC9tqaAZHvg@mail.gmail.com>
2018-02-07 23:17   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180205182352.277832238@linuxfoundation.org \
    --to=gregkh@linuxfoundation.org \
    --cc=alexander.levin@microsoft.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlyle@lyle.org \
    --cc=stable@vger.kernel.org \
    --cc=vojtech@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).