[PATCH 4.4.y 1/2] drm: rcar-du: Use the VBK interrupt for vblank events

[PATCH 4.4.y 1/2] drm: rcar-du: Use the VBK interrupt for vblank events

[Nhan Nguyen]

From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

commit cbbb90b0c084d7dfb2ed8e3fecf8df200fbdd2a0 upstream.

When implementing support for interlaced modes, the driver switched from
reporting vblank events on the vertical blanking (VBK) interrupt to the
frame end interrupt (FRM). This incorrectly divided the reported refresh
rate by two. Fix it by moving back to the VBK interrupt.

Fixes: 906eff7fcada ("drm: rcar-du: Implement support for interlaced modes")

Cc: stable@vger.kernel.org
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: thongsyho <thong.ho.px@rvc.renesas.com>
Signed-off-by: Nhan Nguyen <nhan.nguyen.yb@renesas.com>
---
 drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
index 9befd62..25bdab6 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
@@ -531,7 +531,7 @@ static irqreturn_t rcar_du_crtc_irq(int irq, void *arg)
 	status = rcar_du_crtc_read(rcrtc, DSSR);
 	rcar_du_crtc_write(rcrtc, DSRCR, status & DSRCR_MASK);
 
-	if (status & DSSR_FRM) {
+	if (status & DSSR_VBK) {
 		drm_handle_vblank(rcrtc->crtc.dev, rcrtc->index);
 		rcar_du_crtc_finish_page_flip(rcrtc);
 		ret = IRQ_HANDLED;
-- 
1.9.1

Re: [PATCH 4.4.y 1/2] drm: rcar-du: Use the VBK interrupt for vblank events

[Greg KH]

On Tue, Feb 06, 2018 at 01:37:08PM +0700, Nhan Nguyen wrote:
> From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> 
> commit cbbb90b0c084d7dfb2ed8e3fecf8df200fbdd2a0 upstream.
> 
> When implementing support for interlaced modes, the driver switched from
> reporting vblank events on the vertical blanking (VBK) interrupt to the
> frame end interrupt (FRM). This incorrectly divided the reported refresh
> rate by two. Fix it by moving back to the VBK interrupt.
> 
> Fixes: 906eff7fcada ("drm: rcar-du: Implement support for interlaced modes")
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: thongsyho <thong.ho.px@rvc.renesas.com>
> Signed-off-by: Nhan Nguyen <nhan.nguyen.yb@renesas.com>
> ---
>  drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Are you going to send a series for 4.9 for these patches?

thanks,

greg k-h

Re: [PATCH 4.4.y 1/2] drm: rcar-du: Use the VBK interrupt for vblank events

[Nhan Ngoc. Nguyen]

On 2/7/2018 3:31 AM, Greg KH wrote:
> On Tue, Feb 06, 2018 at 01:37:08PM +0700, Nhan Nguyen wrote:
>> From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>>
>> commit cbbb90b0c084d7dfb2ed8e3fecf8df200fbdd2a0 upstream.
>>
>> When implementing support for interlaced modes, the driver switched from
>> reporting vblank events on the vertical blanking (VBK) interrupt to the
>> frame end interrupt (FRM). This incorrectly divided the reported refresh
>> rate by two. Fix it by moving back to the VBK interrupt.
>>
>> Fixes: 906eff7fcada ("drm: rcar-du: Implement support for interlaced modes")
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>> Signed-off-by: thongsyho <thong.ho.px@rvc.renesas.com>
>> Signed-off-by: Nhan Nguyen <nhan.nguyen.yb@renesas.com>
>> ---
>>   drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> Are you going to send a series for 4.9 for these patches?
>
> thanks,
>
> greg k-h
>
Sorry, I'm late. I've just send you!

Thanks,

Re: [PATCH 4.4.y 1/2] drm: rcar-du: Use the VBK interrupt for vblank events

[Nhan Ngoc. Nguyen]

On 2/7/2018 3:31 AM, Greg KH wrote:
> On Tue, Feb 06, 2018 at 01:37:08PM +0700, Nhan Nguyen wrote:
>> From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>>
>> commit cbbb90b0c084d7dfb2ed8e3fecf8df200fbdd2a0 upstream.
>>
>> When implementing support for interlaced modes, the driver switched from
>> reporting vblank events on the vertical blanking (VBK) interrupt to the
>> frame end interrupt (FRM). This incorrectly divided the reported refresh
>> rate by two. Fix it by moving back to the VBK interrupt.
>>
>> Fixes: 906eff7fcada ("drm: rcar-du: Implement support for interlaced modes")
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>> Signed-off-by: thongsyho <thong.ho.px@rvc.renesas.com>
>> Signed-off-by: Nhan Nguyen <nhan.nguyen.yb@renesas.com>
>> ---
>>   drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> Are you going to send a series for 4.9 for these patches?
>
> thanks,
>
> greg k-h
>
Sorry, I'm late. I've just sent you!

Thanks,