From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:37418 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933462AbeBMPmT (ORCPT ); Tue, 13 Feb 2018 10:42:19 -0500 Date: Tue, 13 Feb 2018 16:42:20 +0100 From: Greg Kroah-Hartman To: Ingo Molnar Cc: Jens Axboe , Tetsuo Handa , osandov@fb.com, stable@vger.kernel.org, peterz@infradead.org, torvalds@linux-foundation.org, tglx@linutronix.de, kernel-team@fb.com Subject: Re: sched/wait: Fix add_wait_queue() behavioral change Message-ID: <20180213154220.GD5919@kroah.com> References: <201802102314.AGJ39032.LMFJFtOSOQFVOH@I-love.SAKURA.ne.jp> <9a183b1a-e6e2-bed1-4816-694b54594cbc@kernel.dk> <20180211103203.tt3w3dhlu2bn5bom@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180211103203.tt3w3dhlu2bn5bom@gmail.com> Sender: stable-owner@vger.kernel.org List-ID: On Sun, Feb 11, 2018 at 11:32:03AM +0100, Ingo Molnar wrote: > > * Jens Axboe wrote: > > > On 2/10/18 7:14 AM, Tetsuo Handa wrote: > > > Recently, we are seeing I/O hungup reports. > > > > > > I don't know whether a regression introduced by commit 50816c48997af857 > > > ("sched/wait: Standardize internal naming of wait-queue entries") is relevant. > > > But shouldn't we backport commit c6b9d9a330290144 ("sched/wait: Fix > > > add_wait_queue() behavioral change") to 4.13+ kernels anyway? > > > > Yes, it most certainly should! > > Indeed, the bug was introduced in v4.13 and the fix was included in v4.15, but > it's missing from v4.13 and v4.14 - not sure how I missed that. > > The fix (also attached below) applies cleanly to both v4.13 and v4.14: Now queued up, thanks. greg k-h