From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:44898 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934388AbeBMPsH (ORCPT ); Tue, 13 Feb 2018 10:48:07 -0500 Date: Tue, 13 Feb 2018 16:47:22 +0100 From: Greg Kroah-Hartman To: Rasmus Villemoes Cc: stable@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: Commit bc137dfdbec2 (watchdog: gpio_wdt: set WDOG_HW_RUNNING in gpio_wdt_stop) Message-ID: <20180213154722.GC14300@kroah.com> References: <34efe5b3-954c-9c22-470f-9f9706a8a363@prevas.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <34efe5b3-954c-9c22-470f-9f9706a8a363@prevas.dk> Sender: stable-owner@vger.kernel.org List-ID: On Sat, Feb 10, 2018 at 10:56:02PM +0100, Rasmus Villemoes wrote: > Hi stable maintainers > > Can I get you to consider including > > bc137dfdbec2 watchdog: gpio_wdt: set WDOG_HW_RUNNING in gpio_wdt_stop > > in -stable? Without that, any (always-running) gpio watchdog effectively > fails to honour the magic close feature, causing an unexpected reset > shortly after userspace gracefully closes the device. > > Anything containing 3c10bbde10 ("watchdog: core: Clear WDOG_HW_RUNNING > before calling the stop function") probably needs it (i.e. 4.8+), but at > the very least 4.14 and 4.15. Now queued up, thanks. greg k-h