stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	stable <stable@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: objtool warnings on 4.14-stable/gcc-7.3.0
Date: Thu, 15 Feb 2018 15:03:15 +0100	[thread overview]
Message-ID: <20180215140315.GA31443@kroah.com> (raw)
In-Reply-To: <20180214222412.arg77l6vjpkje6pj@treble>

On Wed, Feb 14, 2018 at 04:24:12PM -0600, Josh Poimboeuf wrote:
> On Wed, Feb 14, 2018 at 04:11:15PM +0100, Arnd Bergmann wrote:
> > Hi Josh,
> > 
> > I recently did some randconfig testing with a plain 4.14-stable kernel
> > and gcc-7.3.0, and came across three distinct objtool warnings:
> > 
> > drivers/misc/lkdtm_bugs.o: warning: objtool:
> > lkdtm_CORRUPT_LIST_ADD()+0x15: return with modified stack frame
> > 
> > crypto/asymmetric_keys/x509_cert_parser.o: warning: objtool:
> > x509_note_pkey_algo()+0xa4: sibling call from callable instruction
> > with modified stack frame
> > 
> > drivers/infiniband/hw/bnxt_re/qplib_fp.o: warning: objtool:
> > bnxt_qplib_poll_cq()+0x106: sibling call from callable instruction
> > with modified stack frame
> > 
> > It's likely that this is the complete set at the moment, I saw each
> > one multiple times,
> > but did not see any others. I'll reply with the respective object
> > files for your reference,
> > in case these are so far unknown to you. There are only a handful of randconfig
> > warnings we see overall in the kernel these days (at least on x86 and arm64), so
> > even if they are false-positive, it would be great to get rid of the
> > output so we can
> > do randconfig testing on 4.14.y and treat any output from 'make -s' as
> > a regression.
> > I did not check
> 
> The third one has been fixed upstream with
> 
>   99ce7962d52d ("objtool: Fix switch-table detection")
> 
> ... so we should put that one into stable.

Now queued up, thanks.

greg k-h

      parent reply	other threads:[~2018-02-15 14:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 15:11 objtool warnings on 4.14-stable/gcc-7.3.0 Arnd Bergmann
2018-02-14 22:24 ` Josh Poimboeuf
2018-02-14 22:45   ` Josh Poimboeuf
2018-02-15 14:04     ` Greg KH
2018-02-15 15:01     ` Arnd Bergmann
2018-02-15 15:25       ` Josh Poimboeuf
2018-02-15 15:59         ` Arnd Bergmann
2018-02-15 18:06           ` Kees Cook
2018-02-16  3:41             ` Kees Cook
2018-02-16 15:11               ` Arnd Bergmann
2018-02-28  2:20     ` Josh Poimboeuf
2018-02-28 11:26       ` Arnd Bergmann
2018-02-15 14:03   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180215140315.GA31443@kroah.com \
    --to=greg@kroah.com \
    --cc=arnd@arndb.de \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).