public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mario.Limonciello@dell.com
Cc: stable@vger.kernel.org, andriy.shevchenko@linux.intel.com
Subject: Re: [PATCH] platform/x86: dell-laptop: Allocate buffer on heap rather than globally
Date: Thu, 15 Feb 2018 15:27:46 +0100	[thread overview]
Message-ID: <20180215142746.GB4200@kroah.com> (raw)
In-Reply-To: <c8d73dd5373e4711b88f020e644e5387@ausx13mpc120.AMER.DELL.COM>

On Tue, Feb 13, 2018 at 07:54:10PM +0000, Mario.Limonciello@dell.com wrote:
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Tuesday, February 13, 2018 1:52 PM
> > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> > Cc: linux-stable <stable@vger.kernel.org>; Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com>
> > Subject: Re: [PATCH] platform/x86: dell-laptop: Allocate buffer on heap rather than
> > globally
> > 
> > On Tue, Feb 13, 2018 at 01:39:19PM -0600, Mario Limonciello wrote:
> > > There is no longer a need for the buffer to be defined in
> > > first 4GB physical address space.
> > >
> > > Furthermore there may be race conditions with multiple different functions
> > > working on a module wide buffer causing incorrect results.
> > >
> > > This commit has been backported from:
> > > commit 9862b43624 upstream
> > >
> > > Fixes: 549b4930f057658dc50d8010e66219233119a4d8
> > > Suggested-by: Pali Rohar <pali.rohar@gmail.com>
> > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > >  drivers/platform/x86/dell-laptop.c | 188 ++++++++++++++++++++-----------------
> > >  1 file changed, 103 insertions(+), 85 deletions(-)
> > 
> > Why is this a stable patch?  What bug does it fix?
> > 
> > confused,
> > 
> > greg k-h
> 
> Greg,
> 
> I realized I forgot to send this 2 weeks ago when you said a clean backport
> didn't work.  This was a follow up from a race condition that was seen in
> the wild and submitted to platform-x86.

Ok, what kernel tree(s) do you want it applied to?  I need a hint please :)

thanks,

greg k-h

  reply	other threads:[~2018-02-15 14:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13 19:39 [PATCH] platform/x86: dell-laptop: Allocate buffer on heap rather than globally Mario Limonciello
2018-02-13 19:51 ` Greg KH
2018-02-13 19:54   ` Mario.Limonciello
2018-02-15 14:27     ` Greg KH [this message]
2018-02-15 14:50       ` Mario.Limonciello
2018-02-27 15:01         ` Mario.Limonciello
2018-02-27 18:30           ` Greg KH
2018-02-27 18:34             ` Mario.Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180215142746.GB4200@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Mario.Limonciello@dell.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox