From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:34988 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336AbeBTKkW (ORCPT ); Tue, 20 Feb 2018 05:40:22 -0500 Date: Tue, 20 Feb 2018 11:40:25 +0100 From: Greg Kroah-Hartman To: Guenter Roeck Cc: Yves-Alexis Perez , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, shuahkh@osg.samsung.com, patches@kernelci.org, ben.hutchings@codethink.co.uk, lkft-triage@lists.linaro.org, stable@vger.kernel.org Subject: Re: [PATCH 4.9 00/92] 4.9.81-stable review Message-ID: <20180220104025.GA9589@kroah.com> References: <20180209133931.211869118@linuxfoundation.org> <556ea00b-e265-7f14-395c-c5e6629bf194@roeck-us.net> <20180213093651.GA29675@kroah.com> <7c1ed8b1-bd9c-4b9f-051b-f9f19591cdbb@roeck-us.net> <20180213152907.GA29190@kroah.com> <1518874313.9465.1.camel@debian.org> <20180217134556.GC28145@kroah.com> <3075ec06-df9e-3532-82fa-cb2ca227c86b@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3075ec06-df9e-3532-82fa-cb2ca227c86b@roeck-us.net> Sender: stable-owner@vger.kernel.org List-ID: On Sat, Feb 17, 2018 at 09:35:59AM -0800, Guenter Roeck wrote: > On 02/17/2018 05:45 AM, Greg Kroah-Hartman wrote: > > On Sat, Feb 17, 2018 at 02:31:53PM +0100, Yves-Alexis Perez wrote: > > > On Tue, 2018-02-13 at 16:29 +0100, Greg Kroah-Hartman wrote: > > > > > arch/powerpc/kernel/entry_64.S: Assembler messages: > > > > > arch/powerpc/kernel/entry_64.S:260: Error: unrecognized opcode: `rfi_to_user' > > > > > arch/powerpc/kernel/entry_64.S:270: Error: unrecognized opcode: `rfi_to_kernel' > > > > > arch/powerpc/kernel/entry_64.S:885: Error: unrecognized opcode: `rfi_to_user' > > > > > arch/powerpc/kernel/entry_64.S:900: Error: unrecognized opcode: `rfi_to_kernel' > > > > > > > > > > Looks like 222f20f140623 ("powerpc/64s: Simple RFI macro conversions") is missing, > > > > > or at least part of it. Unfortunately it doesn't apply cleanly. > > > > > > > > Ugh. Let's see if the ppc developers care about this or not :) > > > > > > Hi, > > > > > > in Debian we extracted the following hunk from 222f20f140623 to fix build on > > > powerpc/ppc64el. Only compile tested against Debian builds though. > > > > > > diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S > > > index 3320bcac7192..e68faa4d1b13 100644 > > > --- a/arch/powerpc/kernel/entry_64.S > > > +++ b/arch/powerpc/kernel/entry_64.S > > > @@ -37,6 +37,11 @@ > > > #include > > > #include > > > #include > > > +#ifdef CONFIG_PPC_BOOK3S > > > +#include > > > +#else > > > +#include > > > +#endif > > > > Ah, thanks! I've now queued up this portion of the patch. > > > > Hmm, that chunk really doesn't do what the original patch is supposed to do, > meaning it won't provide the vulnerability protection it is supposed to provide > (AFAICS that is Meltdown). Just a note in case anyone is concerned about > actually providing that protection. Good point, I've renamed this patch now to make it more obvious what is going on. thanks, greg k-h